Skip to content

Comments

Add student evelyn bushell#136

Open
Eveybushell wants to merge 2 commits intoSeattleColleges:mainfrom
Eveybushell:add-student-Evelyn-Bushell
Open

Add student evelyn bushell#136
Eveybushell wants to merge 2 commits intoSeattleColleges:mainfrom
Eveybushell:add-student-Evelyn-Bushell

Conversation

@Eveybushell
Copy link

Summary & Changes 📃

  • Added my information and picture: 122

  • Summary: (Briefly describe what this PR does)

    • I have added my information to the students json and included my webp picture in the pictures file
    • You will see my card on the Students page
  • Changes:

    • My information was added to the Students page
    • Removing react-scripts due to vulnerability issues broke the page, so I brought it back again
My entry is: "name": "Evelyn Bushell", "photo": "Evelyn-Bushell.webp", "role": " Student Developer", "about": "A Junior student who loves the puzzles of problem solving, I love just how many different things there are to learn.", "email": "evelynabushell@gmail.com", "github": "https://github.com/Eveybushell", "linkedin": "https://www.linkedin.com/in/evelyn-bushell-6a475639a/"

Checklist ✅

  • [x ] I have tested this PR locally and it works as expected.
  • [x ] This PR resolves an issue (Resolves #issue-number).
  • [x ] Reviewers, assignees(self), tags, and labels are correctly assigned.
  • [x ] Squash commits and enable auto-merge if approved.

react-scripts was flagged as a vulnerability but seems to be necessary.
Copy link

@SUPER444E SUPER444E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added profile looks good, and runs properly on-site

Good job handling this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to discuss administrators before changing/updating package.json , it's not something to do in this specific PR, so submit a new issue if you think this is a notable change

Copy link

@elbi3 elbi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I tested this locally on my machine. All the links work, photo paints to the page, love the bio statement :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants