Skip to content

Comments

Add Eric Cashman to Students Page#135

Open
Eric-Cashman wants to merge 1 commit intoSeattleColleges:mainfrom
Eric-Cashman:add-student-Eric-Cashman
Open

Add Eric Cashman to Students Page#135
Eric-Cashman wants to merge 1 commit intoSeattleColleges:mainfrom
Eric-Cashman:add-student-Eric-Cashman

Conversation

@Eric-Cashman
Copy link

Description

Added my name to the Students Page as part of the onboarding task.

Related Issue

Closes #122

Summary & Changes 📃

  • Resolves: #122
  • Summary: Added Eric Cashman to the Students Page with profile photo
    • 🔨 What does this issue fix?
      • Completes onboarding task by adding new student to the roster
    • 👀 What is the expected behavior?
      • My name and photo now appear on the Students Page alongside other students
    • 🗨️ Any relevant technical details?
      • Added profile photo in WebP format to images/students/
      • Updated students.html (or Students.jsx) with new student entry
      • Followed existing format and naming conventions
  • Changes:
    • ✅ Added profile photo: images/students/your-name.webp
    • ✅ Updated students list with name entry
    • ✅ Maintained consistent formatting with existing students
    • 🛠️ No breaking changes
    • 🔗 Issue Students Page: Add yourself to the Students Page #122
    • 📝 This is my first contribution to the repository

Screenshots / Visual Aids 🔎

📌 Required for: UI changes, layout updates, or bug fixes.

Details studentscreenshot

How to Test 🧪

  1. Steps to Reproduce:

    • Step 1: Check out this branch: git checkout add-student-Eric-Cashman
    • Step 2: Run npm install and npm start
    • Step 3: Navigate to the Students Page
    • Step 4: Verify Eric Cashman appears in the students list
    • Step 5: Verify profile photo loads correctly
  2. Expected Behavior:

    • Students Page displays with my name and photo
    • Photo loads without errors
    • Layout remains consistent with other students
    • No console errors
  3. Actual Behavior:

    • Works as expected ✅

Checklist ✅

Copy link

@nhapham03 nhapham03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job on your first PR Eric👍

Image

Copy link

@SUPER444E SUPER444E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, runs well

@Dhool143
Copy link

looks good Eric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Students Page: Add yourself to the Students Page

4 participants