nsc-events-fullstack_30_135_e2e-schema-fix-and-ci-opt

[NahomAlemu]

Summary & Changes 📃

• Resolves:
  Bug Report: Fix E2E Tests for ERD Schema Refactor Compatibility #150
  Issue: Update dbFieldMapper Utility for New Schema Fields #152

• Related To: nsc-events-fullstack_30_130_erd-schema-refactoring #142

• Summary: - 🔨 What does this issue fix? Fixes E2E failures due to schema changes and optimizes the Playwright CI pipeline. In addition included changes to backend returns tags as Tag objects instead of eventTags as strings these changes ensure frontend compatibility.

• 👀 What is the expected behavior? Successful E2E runs using corrected endpoints and a "Smart CI" that scales based on file changes.

• 🗨️ Any relevant technical details? Transitioned from a "run-all" approach to a tiered strategy: Smoke Tests for UI changes vs. Full Sharded Suite for critical backend/logic changes.

• Changes:

  • Endpoint Update:** Fixed delete path to /events/remove/${id} in api-client.ts.
  • DTO Alignment:** Updated eventTags → tagNames in event-management.spec.ts.
  • CI Optimization:** Implemented path-based filtering and 2-way parallel sharding.
  • Manual Trigger:** Added workflow_dispatch to allow manual scope selection (Smoke/Critical/Full).
    Backend:
  • activity.service.ts: Added relations: ['tags', 'coverPhoto',
    'document'] to getActivityById() to include tag data in API
    responses
    Frontend Data Layer:
  • dbFieldMapper.ts: Added tags→eventTags transformation to
    convert Tag objects ([{id, name, slug}]) to string arrays
    (["Tech", "Social"])
    Frontend Components (Defensive Coding):
  • EditDialog.tsx: Added null-safe fallback for .join() on
    eventTags
  • HomeEventsCard.tsx: Added null-safe fallback for .map() on
    eventTags
    Unit Test Updates:
  • activity.service.spec.ts: Updated mock expectation to include
    new relations
  • dbFieldMapper.test.ts: Updated 6 tests to expect eventTags: []
    in normalized output

• 📝 Efficiency: Reduced average CI runtime for non-critical PRs.

Screenshots / Visual Aids 🔎

_{📌 Required for: UI changes, layout updates, or bug fixes.}

Expand ⬇️

How to Test 🧪

Steps to Reproduce:
0. If you have the old schema, please makesure to drop the schema and run the application again.
run this quary in pgAdmin:
DROP SCHEMA public CASCADE; CREATE SCHEMA public;

1. Run full E2E suite npx playwright test
2. Run Unit Tests: npm run test
3. Manual Verification:
   • Create a new event with tags → Verify tags display on event
     detail page
   • Edit an existing event → Verify tags load correctly in the
     edit dialog
   • View event cards on home page → Verify tags render without
     console errors
     Expected Behavior:

• All E2E tests and unit-test pass

Checklist ✅

• I have tested this PR locally and it works as expected.
• This PR resolves an issue (Resolves #135).
• Reviewers, assignees(self), tags, and labels are correctly assigned.
• Squash commits and enable auto-merge if approved.

[github-actions]

✅ Full E2E Test Results

Running full test suite (critical files changed)

Status	Count
✅ Passed	0
❌ Failed	0
📊 Total	0

View detailed report

[github-actions]

✅ Full E2E Test Results

Running full test suite (critical files changed)

Status	Count
✅ Passed	47
❌ Failed	0
📊 Total	47

View detailed report

[beimnettes]

I checked the branch and all CI checks are passing.
The changes align with the related issues and look good.
No blockers from my side.

[TVW96]

Can connect to database from client. Cannot connect from Postman.

E2E test's are outputting flaky test which vary depending on test refresh rate. There is also about a dozen tests that we are skipping. Can we fix these before pushing this PR?

Unit test are all green. 🪴

[NahomAlemu]

E2E test's are outputting flaky test which vary depending on test refresh rate. There is also about a dozen tests that we are skipping. Can we fix these before pushing this PR?

Thanks for the thorough review, Troy!

1. The 500 error on /api/events is reproducible from both the UI and Postman as shown in the screenshot, the frontend also returns no events. It's not a Postman-specific issue the issue "not being able to connect to the database" might be in the set up but all events was not showing up, and it is fixed now.

2. Regarding flaky tests, these are pre-existing and not introduced by this PR. Retries are already configured in playwright.config.ts (retries: 2 on CI, retries: 1 locally), so Playwright is already handling transient failures per its recommended approach. The root cause of flakiness in E2E tests like ours is typically race conditions or timing variance across environments, which is a broader codebase concern. I'll open a separate issue to investigate and address the underlying causes (e.g. replacing any waitForTimeout() calls with proper auto-waiting assertions). Here's the relevant Playwright docs for reference: https://playwright.dev/docs/test-retries

3. Of the 12 skipped tests shown, 5 are intentionally skipped in the initial Playwright tests branch. The rest are surfacing from the unit test file as a result. The 5 skipped, fall into two categories: the Material UI date picker in our UI is difficult for Playwright to interact with (the test is kept for future use), and a few redirect simulation tests that were extra and can be iterated on. I covered this in the Playwright demo, but I'll document it now since it wasn't written down.

These are all valid observations, but none are regressions introduced by this PR. I'll create separate issues for tracking. Happy to move further discussion to the GitHub Discussions section for visibility.

[github-actions]

✅ Full E2E Test Results

Running full test suite (critical files changed)

Status	Count
✅ Passed	53
❌ Failed	0
📊 Total	53

View detailed report

[github-actions]

✅ Full E2E Test Results

Running full test suite (critical files changed)

Status	Count
✅ Passed	47
❌ Failed	0
📊 Total	47

View detailed report