Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Comments

nextwavedev_22_6_nscad-to-nextwavedev#7

Merged
bcko merged 3 commits intomainfrom
6-issue-nsc-ad-to-next-wave-dev
May 2, 2025
Merged

nextwavedev_22_6_nscad-to-nextwavedev#7
bcko merged 3 commits intomainfrom
6-issue-nsc-ad-to-next-wave-dev

Conversation

@jmathew12
Copy link
Contributor

@jmathew12 jmathew12 commented May 1, 2025

Summary & Changes 📃

This pr resolves multiple tickets

  • Summary: (Briefly describe what this PR does)
    This pr resolves multiple tickets related to converting the nsc ad website to next wave dev website.

  • Changes:

    • ✅ List key changes made
  • Change Home Page Text NSC AD to Next Wave Dev

  • Change Students to Developers in navbar

  • Change email address on the contact form

  • Change about page title and description

  • Change our students to our developers on developers(former students) page

  • Refactor files and variables that are named students to developers (currently not on a ticket)

    • 🛠️ Mention breaking changes (if any)
      Some of the filenames and variable names were changed, this could potentially break the site. Students was replaced by Developers
    • 🔗 Link relevant discussions/issues
    • 📝 Additional info to assist developers & reviewers
      Renaming files and variables from Students to developers - This is a breaking change that could be problamatic.

Screenshots / Visual Aids 🔎

📌 Required for: UI changes, layout updates, or bug fixes.

Expand ⬇️

Screenshot from 2025-04-30 21-32-57
Screenshot from 2025-04-30 21-32-48
Screenshot from 2025-05-05 20-28-42
Screenshot from 2025-05-05 20-29-20

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: Run project: npm start
    • Step 2: check home page, about page, contact, and developers page
  2. Expected Behavior: (Describe what should happen)
    -NSC AD titles should be replaced with Next Wave Dev and Students should be replaced by developers
  3. Actual Behavior (if bug): (Describe what happens instead)

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves Issue: NSC AD to Next Wave Dev #6 ) .
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

@jmathew12 jmathew12 added enhancement New feature or request Sprint 22 labels May 1, 2025
@jmathew12 jmathew12 requested review from a team and bcko May 1, 2025 04:45
@jmathew12 jmathew12 self-assigned this May 1, 2025
@jmathew12 jmathew12 requested review from BradleyCharles, IsaacJrTypes, TVW96, cshimm, gitbiruk2010 and nwm516 and removed request for a team May 1, 2025 04:45
@jmathew12 jmathew12 linked an issue May 1, 2025 that may be closed by this pull request
6 tasks
@bcko bcko enabled auto-merge (squash) May 1, 2025 04:47
@el-riber el-riber self-requested a review May 1, 2025 06:24
Copy link

@el-riber el-riber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is working great!
Screenshot_30-4-2025_233041_localhost
Screenshot_30-4-2025_232948_localhost

Copy link

@bcko bcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

@bcko bcko merged commit b6dabcd into main May 2, 2025
@bcko bcko deleted the 6-issue-nsc-ad-to-next-wave-dev branch May 2, 2025 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request Sprint 22

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: NSC AD to Next Wave Dev

3 participants