Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Comments

NextWaveDev_23_12_Optimizing-Image#15

Merged
bcko merged 1 commit intomainfrom
12-make-image-optimized
May 15, 2025
Merged

NextWaveDev_23_12_Optimizing-Image#15
bcko merged 1 commit intomainfrom
12-make-image-optimized

Conversation

@LiteWilliamNguyen
Copy link
Contributor

@LiteWilliamNguyen LiteWilliamNguyen commented May 13, 2025

Optimized imaged with squoosh.app and then changing file type in students.json

Summary & Changes 📃

  1. Optimizing all photo in image folder using squoosh.app by compressing with WebP by Effort = 4 and Quality =75 unless image is over 1GB.
  2. Changed all file type in photo value in student.json. From either PNG and JPG to WEBP
  • Changes:
    -Photo size
  • file type in value for each key: photo

Screenshots / Visual Aids 🔎

image
image
Each file are compressed down to less than 1GB
image

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: npm start in terminal or VS code
  2. Expected Behavior: image and all detail should be there.

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves #issue-number).
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

Optimized imaged with squoosh.app and then changing file type in students.json
Copy link

@bcko bcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@bcko bcko enabled auto-merge (squash) May 13, 2025 17:29
Copy link

@itsvee0120 itsvee0120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me when I tested and looks great. I like that you are using squoosh.app since it works locally and we don't have to worry about privacy issue!

@bcko bcko merged commit 2adbb21 into main May 15, 2025
@bcko bcko deleted the 12-make-image-optimized branch May 15, 2025 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants