Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Comments

nextwavedev_sprint22_issue10_updating-footer-information#11

Merged
JesseCaddell merged 1 commit intomainfrom
10-issue-updating-footer-information
May 12, 2025
Merged

nextwavedev_sprint22_issue10_updating-footer-information#11
JesseCaddell merged 1 commit intomainfrom
10-issue-updating-footer-information

Conversation

@AzariasANeals
Copy link
Contributor

@AzariasANeals AzariasANeals commented May 8, 2025

Summary & Changes 📃

  • Resolves: Issue Issue: Updating footer information. #10: updating the footer information for Next Wave Dev

  • Summary:
    Updated the information in the footer for Next Wave Dev.

    • Changed "students" to "developers" instead.
    • Changed contact us email to nextwavedev.org@gmail.com
    • Removed the "become a student" form from the footer
    • Updated the logo from the Tree Frogs to the NextWaveDev logo.

-Description:
- I've noticed that the logo kind of blends into the background and is a little hard to read, so it might be nice to change the background color of the footer/header.
- The NextWaveDev logo still links to northseattle.edu when clicked. I'm not sure if there was another link you would want it to link to. Perhaps nextwavdev.org? If that is what the domain name is.

Screenshots / Visual Aids 🔎

Previously looked like:
issue-1

Currently looks like:
updated-screenshot-1
Screenshot 2025-05-07 213635

How to Test 🧪

  1. Steps to Reproduce:
    • Type "npm start" in the terminal
    • Scroll to the bottom of the page and check to make sure the changes have been applied to the footer.
  2. Expected Behavior: You should see the footer with the updated information
  3. Actual Behavior (if bug): You should see the footer with the updated information

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves #issue-number).
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

Copy link
Contributor

@beimnettes beimnettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed locally! The footer updates look great:

  • “Students” was successfully changed to “Developers”
  • The email address now shows nextwavedev.org@gmail.com
  • The “Become a student” form is removed
  • The logo has been updated to the NextWaveDev version

Thanks for clearly documenting your changes and providing before/after visuals. Great work!

Here’s a screenshot of the updated footer from my local test:
Screenshot 2025-05-11 at 9 56 07 AM

Copy link
Contributor

@LiteWilliamNguyen LiteWilliamNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Confirmed locally as well.
The footer updates look great! The changes align well with the branding and purpose of Next Wave Dev. The description have been changed, and the width have been changed to fit the site better.

@el-riber el-riber self-requested a review May 11, 2025 22:52
Copy link

@el-riber el-riber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is working as expected!

Copy link

@MiguelQuintana1 MiguelQuintana1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

footer works great. Good Job!!

GMT20250512-062122_Clip_Miguel.Quintana.s.Clip.05_11_2025.mp4

@JesseCaddell JesseCaddell merged commit 7a8af63 into main May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request Sprint 22

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: Updating footer information.

6 participants