Fill defaults from existing generation config if present.#72
Open
droans wants to merge 1 commit intoSearchSavior:mainfrom
Open
Fill defaults from existing generation config if present.#72droans wants to merge 1 commit intoSearchSavior:mainfrom
droans wants to merge 1 commit intoSearchSavior:mainfrom
Conversation
Owner
|
Fantastic. I'll add to vlm pipeline before merging since the interface is the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
self.modelis defined for the OVGenAi_LLM class,generation_kwargsare pulled fromself.model.get_generation_configinstead of creating a new instance usingGenerationConfig(). This allows for users to retain the defaults set by the model for each config if they have not chosen to adjust it.