Open
Conversation
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker,
brayan-trejo and
foodprocessor
as code owners
foodprocessor
approved these changes
Feb 2, 2026
Comment on lines
+449
to
+452
| v, err := mem.VirtualMemory() | ||
| if err != nil { | ||
| return err | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe we should rather default to a reasonable choice for StreamOnly, instead of returning this error?
My AI tells me the error would be extremely rare, but even so, I don't see the point of letting it crash the operation.
Contributor
There was a problem hiding this comment.
Similar thought could be put into the other places where this is used, since it introduces a new exception path in every case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
Remove memory dependency which has not been updated in 5 years. Replaces call to get free memory with psutil library which we already include in cloudfuse.
Checklist
Related Issues