Add deserializer for amf0 value and fix amf0 visitor fns

CONTRIBUTING.md

@@ -43,7 +43,13 @@ cargo install cargo-binstall
 then all of the other crates can be installed with `cargo binstall`.
 
 ```bash
-cargo binstall just cargo-llvm-cov cargo-nextest cargo-insta cargo-hakari miniserve
+cargo binstall just cargo-llvm-cov cargo-nextest cargo-insta cargo-hakari miniserve taplo
+```
+
+Note that for `cargo-sync-rdme` we use Troy's custom fork:
+
+```bash
+cargo binstall cargo-sync-rdme --git https://github.com/TroyKomodo/cargo-sync-rdme.git --force -y
 ```
 
 </details>

Justfile

@@ -7,9 +7,10 @@ export RUST_TOOLCHAIN := env_var_or_default('RUST_TOOLCHAIN', 'nightly')
 powerset *args:
     cargo +{{RUST_TOOLCHAIN}} xtask powerset {{args}}
 
-# An alias for cargo fmt --all
+# An alias for cargo fmt --all and taplo fmt for TOML files.
 fmt *args:
     cargo +{{RUST_TOOLCHAIN}} fmt --all {{args}}
+    taplo fmt
 
 lint *args:
     cargo +{{RUST_TOOLCHAIN}} clippy --fix --allow-dirty --allow-staged --all-features --all-targets {{args}} -- -Aclippy::collapsible_if

changes.d/pr-441.toml

@@ -0,0 +1,24 @@
+[[scuffle-amf0]]
+category = "fix"
+description = "Fix amf0 deserialization to abide by better deserialization standards"
+authors = ["@philipch07", "@TroyKomodo"]
+
+[[scuffle-amf0]]
+category = "fix"
+description = "Fix `Amf0Object` to be represented by a BTreeMap instead of a hashmap to guarantee consistency when iterating through the map"
+authors = ["@TroyKomodo"]
+
+[[scuffle-amf0]]
+category = "fix"
+description = "Fix `Amf0Array` to be represented by a vec instead of a cow which is more appropriate for the type"
+authors = ["@TroyKomodo"]
+
+[[scuffle-amf0]]
+category = "feat"
+description = "Add an Amf0Value deserializer"
+authors = ["@philipch07", "@TroyKomodo"]
+
+[[scuffle-bytes-util]]
+category = "feat"
+description = "Add an `IntoDeserializer` implementation for a `&StringCow`"
+authors = ["@TroyKomodo"]

crates/amf0/Cargo.toml

@@ -17,22 +17,26 @@ byteorder = "1.5"
 bytes = "1.10.1"
 bytestring = "1.4.0"
 document-features = { optional = true, version = "0.2" }
+indexmap = { optional = true, version = "2.4.0" }
 num-derive = "0.4"
 num-traits = "0.2"
-scuffle-bytes-util = { path = "../bytes-util", version = "0.1.3" }
+scuffle-bytes-util = { path = "../bytes-util", version = ">=0.1.4" }
 scuffle-changelog = { optional = true, path = "../changelog", version = "0.1.0" }
 scuffle-workspace-hack.workspace = true
 serde = { optional = true, version = "1" }
 thiserror = "2.0"
 
 [dev-dependencies]
+insta = "1.42"
 serde_derive = "1"
 
 [features]
 ## Enables serde support
 serde = ["dep:serde", "scuffle-bytes-util/serde"]
 ## Enables changelog and documentation of feature flags
 docs = ["dep:scuffle-changelog", "dep:document-features"]
+## Use an index map instead of a btree-map for Amf0Objects
+preserve_order = ["dep:indexmap"]
 
 [package.metadata.docs.rs]
 all-features = true

crates/amf0/README.md

@@ -26,6 +26,7 @@ See the [changelog](./CHANGELOG.md) for a full release history.
 
 * **`serde`** —  Enables serde support
 * **`docs`** —  Enables changelog and documentation of feature flags
+* **`preserve_order`** —  Use an index map instead of a btree-map for Amf0Objects
 
 ### Specification