Skip to content

feat: add character criteria#279

Open
perappu wants to merge 39 commits intoScuffedNewt:extension/criteria-developfrom
perappu:extension-pr/criteria-develop
Open

feat: add character criteria#279
perappu wants to merge 39 commits intoScuffedNewt:extension/criteria-developfrom
perappu:extension-pr/criteria-develop

Conversation

@perappu
Copy link

@perappu perappu commented Mar 10, 2026 •
edited
Loading

I leave my child in your capable hands, also updated it to latest develop while I was at it

The temptation is there to use data on SubmissionCharacter for both rewards and criteria (kinda like on submissions themselves), but imho this is the path of least resistance, would otherwise be too much overhaul to be worth it. You'd have to make a conversion command for existing SubmissionCharacters among a bunch of other stuff and like, ehhhh, but godspeed if that's where your heart takes you

perappu and others added 30 commits December 20, 2025 04:46
@perappu
fix(users): get lowest existing rank when creating new user (lk-arpg#…
713f962 
…1385)
@Draconizations
fix: fix showRaffles check in loot js view (lk-arpg#1397)
15fa6bd
@SpeedyD
fix: check filemtime in admin site images panel (lk-arpg#1398)
3443af4
@SpeedyD
fix(traits): fix typo, config value reference for species-only traits…
69a820e 
… in dropdowns (lk-arpg#1401)
@itinerare
chore: update from release/v3.0.0
988ed8a
@dependabot
chore(deps-dev): bump sass from 1.97.1 to 1.97.2 (lk-arpg#1403)
5cf4c0a 
Bumps [sass](https://github.com/sass/dart-sass) from 1.97.1 to 1.97.2.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.97.1...1.97.2)

---
updated-dependencies:
- dependency-name: sass
  dependency-version: 1.97.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ScuffedNewt
feat(prompts): add prompt sub-categories (lk-arpg#1400)
0a0f234
@SpeedyD
fix(characters): clarify character edit button labels (lk-arpg#1404)
6a42ac5 
* fix(character): Minor button renaming

* Change 'Edit Notes' to 'Edit Description'

* Change 'Edit Features' to 'Edit Traits' link text
@ScuffedNewt @JuniJwi
feat(prompts): add prompt limits (lk-arpg#1389)
cff830e 
* prompt limitations added to the submission process.

* fixed typos in display

* fixing the carbon bug which mis-saves time during the transition of time

* removed unnecessary "Carbon::"

* missed a fix on submission checks!

* wrong variable for submission creation

* refactor: fix blade formatting

* refactor: fix PHP styling

* feat: allow submissions after prompt closing if there are staff comments

* feat: more limit period options

---------

Co-authored-by: JuniJwi <junikimdraws@gmail.com>
Co-authored-by: ScuffedNewt <ScuffedNewt@users.noreply.github.com>
@perappu
fix(shops): only check date if shop is timed in active check (lk-arpg…
ed8d9ab 
…#1408)

* fix(shops): shop being displayed as inactive when is_timed_shop is false but date data still exists

* refactor: fix PHP styling

---------

Co-authored-by: perappu <perappu@users.noreply.github.com>
@liwoyadan
fix(browse): verify owner/artist/designer existence in ML search (lk-…
c672491 
…arpg#1410)
@SpeedyD
fix(prompts): use idUrl in prompt display names (lk-arpg#1414)
04a3511
@SpeedyD
feat(prompts): make prompt search consistent between public/admin ind…
70e1234 
…ex (lk-arpg#1415)
@MarskyMessier
fix(loot): update reward reference (lk-arpg#1413)
3031e46
@itinerare
chore: update from release/v3.0.0
2436a58
@dependabot
chore(deps-dev): bump lodash from 4.17.21 to 4.17.23 (lk-arpg#1419)
78dd77d 
* chore(deps-dev): bump lodash from 4.17.21 to 4.17.23

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.17.23
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): rebuild mix assets

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump sass from 1.97.2 to 1.97.3 (lk-arpg#1421)
e396997 
Bumps [sass](https://github.com/sass/dart-sass) from 1.97.2 to 1.97.3.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.97.2...1.97.3)

---
updated-dependencies:
- dependency-name: sass
  dependency-version: 1.97.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump axios from 1.13.2 to 1.13.3 (lk-arpg#1420)
d97e529 
* chore(deps-dev): bump axios from 1.13.2 to 1.13.3

Bumps [axios](https://github.com/axios/axios) from 1.13.2 to 1.13.3.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.13.2...v1.13.3)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.13.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): rebuild mix assets

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@SpeedyD
feat(sales): make search, sort consistent between public/admin index (l…
75089da 
…k-arpg#1416)

* QoL(Sales): Sort and search functions synchronisation

* refactor: fix PHP styling

* Forgot Request $request

---------

Co-authored-by: SpeedyD <SpeedyD@users.noreply.github.com>
@SpeedyD
feat(news): add sort and search functions to public, admin indices (l…
905deef 
…k-arpg#1417)

* Qol(News): Sort and search functions

* Forgot Request $request AND left a chunk of code in by accident
@SpeedyD
fix(news): fix admin index view path (lk-arpg#1423)
ef1ca3f
@SpeedyD
fix: fix news/sales default sort value (lk-arpg#1422)
b910c7d
@dependabot
chore(deps-dev): bump axios from 1.13.3 to 1.13.4 (lk-arpg#1426)
a2c3ccb 
* chore(deps-dev): bump axios from 1.13.3 to 1.13.4

Bumps [axios](https://github.com/axios/axios) from 1.13.3 to 1.13.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.13.3...v1.13.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.13.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): rebuild mix assets

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump sass-loader from 16.0.6 to 16.0.7 (lk-arpg#1428)
adf5960 
Bumps [sass-loader](https://github.com/webpack/sass-loader) from 16.0.6 to 16.0.7.
- [Release notes](https://github.com/webpack/sass-loader/releases)
- [Changelog](https://github.com/webpack/sass-loader/blob/main/CHANGELOG.md)
- [Commits](webpack/sass-loader@v16.0.6...v16.0.7)

---
updated-dependencies:
- dependency-name: sass-loader
  dependency-version: 16.0.7
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump axios from 1.13.4 to 1.13.5 (lk-arpg#1429)
07749c8 
* chore(deps-dev): bump axios from 1.13.4 to 1.13.5

Bumps [axios](https://github.com/axios/axios) from 1.13.4 to 1.13.5.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.13.4...v1.13.5)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.13.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): rebuild mix assets

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@SpeedyD
fix(nav): make dropdown ids unique (lk-arpg#1427)
02c20ae
@itinerare
chore: update from release/v3.0.0
31b02ec
@ScuffedNewt
fix(submissions): fix first drafts not being able to be submitted (lk…
810bbc4 
…-arpg#1431)

* fix: first drafts not being able to be submitted

* refactor: fix PHP styling

---------

Co-authored-by: ScuffedNewt <ScuffedNewt@users.noreply.github.com>
@ScuffedNewt
fix: improve asset recipient handling (lk-arpg#1432)
2c4a675 
* fix: character default assets use character asset keys

* fix: update rewards to be character-aware

* fix: unnecessary ternary

* refactor: fix blade formatting

* fix: display reward types when $showRecipient is true

* fix: stop 500 error if user selects empty recipient

---------

Co-authored-by: ScuffedNewt <ScuffedNewt@users.noreply.github.com>
@notecardPasta
refactor(prompts): move prompt limits count arrays to attribute (lk-a…
ac14255 
…rpg#1434)

* fix(prompts) consolidate all count arrays for prompt limits into one function in the model

* remove auth, I don't think it's needed for here actually?

* filterCount changed to getCount
dependabot bot and others added 9 commits March 2, 2026 08:34
@dependabot
chore(deps-dev): bump axios from 1.13.5 to 1.13.6 (lk-arpg#1435)
1842dc9 
* chore(deps-dev): bump axios from 1.13.5 to 1.13.6

Bumps [axios](https://github.com/axios/axios) from 1.13.5 to 1.13.6.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.13.5...v1.13.6)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.13.6
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): rebuild mix assets

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump postcss from 8.5.6 to 8.5.8 (lk-arpg#1437)
dedba7c 
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.6 to 8.5.8.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.5.6...8.5.8)

---
updated-dependencies:
- dependency-name: postcss
  dependency-version: 8.5.8
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ScuffedNewt
feat(items): add function to grab eligible stacks for debit actions w…
6a6d3f5 
…ithout user selection (lk-arpg#1381)
@perappu
feat: character criterion
1ab2491
@perappu @github-actions
refactor: fix blade formatting
9e0aaa9
@perappu @github-actions
refactor: fix PHP styling
be756af
@perappu
Merge remote-tracking branch 'lorekeeper/develop' into extension-pr/c…
06faa7c 
…riteria-develop
@perappu
Merge branch 'extension-pr/criteria-develop' of https://github.com/pe…
c6fa5d2 
…rappu/lorekeeper into extension-pr/criteria-develop
@perappu @github-actions
refactor: fix PHP styling
41bdf9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@perappu @Draconizations @SpeedyD @itinerare @ScuffedNewt @liwoyadan @MarskyMessier @notecardPasta