chore: remove bun repo config#29
Open
nicomiguelino wants to merge 1 commit intomainfrom
Open
Conversation
- delete bun lockfile and bun test config - switch dependabot updates to npm - preserve test setup via @screenly/edge-apps/test - refresh package-lock after npm install
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Bun-specific repository configuration/lock artifacts, switches Dependabot to track npm updates, and keeps the downstream @screenly/edge-apps/test side-effect behavior by moving the DOM-global initialization into the ./test entrypoint.
Changes:
- Removed Bun repo config (
bunfig.toml) and lockfile (bun.lock). - Updated Dependabot to use the
npmpackage ecosystem. - Moved JSDOM/global DOM setup into
src/test/index.tsand removed the separatesrc/test/setup.tsside-effect module.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/setup.ts | Deleted prior JSDOM/global setup module (previously used for Bun preload / side effects). |
| src/test/index.ts | Inlined DOM globals initialization into the ./test entrypoint and removed the setup re-export. |
| package-lock.json | Replaced/updated lockfile content for npm usage (includes metadata changes for platform-specific packages). |
| bunfig.toml | Removed Bun test preload configuration. |
| bun.lock | Removed Bun lockfile from the repo. |
| .github/dependabot.yml | Switched Dependabot ecosystem from bun to npm and renamed the group accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+2
| import { JSDOM } from 'jsdom' | ||
|
|
Comment on lines
+12
to
+20
| global.document = dom.window.document | ||
| global.window = dom.window as unknown as Window & typeof globalThis | ||
| global.navigator = dom.window.navigator | ||
| global.Node = dom.window.Node | ||
| global.HTMLElement = dom.window.HTMLElement | ||
| global.customElements = dom.window.customElements | ||
| global.getComputedStyle = dom.window.getComputedStyle | ||
| global.SVGSVGElement = dom.window.SVGSVGElement | ||
|
|
Comment on lines
+4
to
+19
| // for downstream Bun tests that need DOM globals. | ||
| const dom = new JSDOM( | ||
| '<!DOCTYPE html><html><head></head><body></body></html>', | ||
| { | ||
| url: 'http://localhost', | ||
| }, | ||
| ) | ||
|
|
||
| global.document = dom.window.document | ||
| global.window = dom.window as unknown as Window & typeof globalThis | ||
| global.navigator = dom.window.navigator | ||
| global.Node = dom.window.Node | ||
| global.HTMLElement = dom.window.HTMLElement | ||
| global.customElements = dom.window.customElements | ||
| global.getComputedStyle = dom.window.getComputedStyle | ||
| global.SVGSVGElement = dom.window.SVGSVGElement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary