Merged
Conversation
🦋 Changeset detectedLatest commit: 6d95eaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for scouterna-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new tabs component to the design system, implementing an interactive tabbed interface with an animated indicator that moves between tabs when they are clicked.
Changes:
- Added
scout-tabsandscout-tabs-tabcomponents with styling and documentation - Updated component template to implement
ComponentInterfaceby default - Added Storybook stories and documentation for the new tabs components
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| plop-templates/component/ui-webc/component.tsx.hbs | Updates component generator template to implement ComponentInterface |
| packages/ui-webc/src/components/tabs/tabs.tsx | Implements main tabs container component with state management and event handling |
| packages/ui-webc/src/components/tabs/tabs.css | Defines styles for tabs container and animated indicator |
| packages/ui-webc/src/components/tabs/readme.md | Auto-generated documentation for tabs component |
| packages/ui-webc/src/components/tabs-tab/tabs-tab.tsx | Implements individual tab component |
| packages/ui-webc/src/components/tabs-tab/tabs-tab.css | Defines styles for individual tab buttons with hover states |
| packages/ui-webc/src/components/tabs-tab/readme.md | Auto-generated documentation for tabs-tab component |
| packages/storybook/src/stories/tabs.stories.tsx | Adds interactive Storybook story demonstrating tabs usage |
| packages/storybook/src/stories/tabs.mdx | Provides documentation and code examples for tabs component |
| packages/storybook/src/stories/tabs-tab.stories.tsx | Adds Storybook story for individual tab component |
| README.md | Adds reference link about Shadow DOM and events |
| .changeset/thin-vans-divide.md | Documents the minor version change for the new tabs component |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35