Skip to content

Comments

feat: new box component#100

Draft
scriptcoded wants to merge 1 commit intomainfrom
dummy-create-box-component
Draft

feat: new box component#100
scriptcoded wants to merge 1 commit intomainfrom
dummy-create-box-component

Conversation

@scriptcoded
Copy link
Member

test pr to see how netlify prints commetn

Copilot AI review requested due to automatic review settings February 20, 2026 14:35
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2026

⚠️ No Changeset found

Latest commit: 000f35c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 20, 2026

Deploy Preview for scouterna-ui failed.

Name Link
🔨 Latest commit 000f35c
🔍 Latest deploy log https://app.netlify.com/projects/scouterna-ui/deploys/6998713dadeb0800088963ac

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR claims to add a "new box component" but actually only adds a documentation file (box.mdx) to the existing my-component directory. The new file is essentially a duplicate of the existing basic.mdx file with only a different title. There's a significant mismatch between the PR title/description and the actual changes.

Changes:

  • Added box.mdx documentation file in packages/ui-webc/src/components/my-component/lab/

Comment on lines +3 to +18
## Loops

{['a', 'b', 'c'].map(item => (
<my-component first={item} last="!" />
))}

## Object props

<my-component
first="Stencil"
middle="'Don't call me a framework'"
last="JS"
test={{
name: 'dummy'
}}
/>
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new file box.mdx is almost identical to the existing basic.mdx file, with only the title being different ("Box Example" vs "Basic Example"). This appears to be duplicate documentation content that doesn't add value. If this is intended to demonstrate a box component, the content should be updated to reflect box-specific examples. Otherwise, this file should be removed.

Suggested change
## Loops
{['a', 'b', 'c'].map(item => (
<my-component first={item} last="!" />
))}
## Object props
<my-component
first="Stencil"
middle="'Don't call me a framework'"
last="JS"
test={{
name: 'dummy'
}}
/>
This page shows how to render `my-component` inside a simple "box" container
using plain HTML and inline styles. You can replace the inline styles with
your own CSS classes in a real application.
## Single boxed component
<div
style={{
border: '1px solid #ccc',
padding: '1rem',
borderRadius: '4px',
backgroundColor: '#f9f9f9',
}}
>
<my-component first="Boxed" middle="single" last="example" />
</div>
## Multiple components in boxes
<div
style={{
display: 'grid',
gap: '0.75rem',
}}
>
{['a', 'b', 'c'].map((item) => (
<div
key={item}
style={{
border: '1px solid #ddd',
padding: '0.75rem',
borderRadius: '4px',
}}
>
<my-component first={item} middle="inside" last="box" />
</div>
))}
</div>
## Box with additional props
<div
style={{
border: '2px dashed #999',
padding: '1rem',
borderRadius: '6px',
}}
>
<my-component
first="Stencil"
middle="'Don't call me a framework'"
last="JS"
test={{
name: 'boxed example',
}}
/>
</div>

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,18 @@
# Box Example
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says "feat: new box component" but the changes only add a documentation file (box.mdx) for the existing my-component. No actual box component is being created. Either:

  1. The PR title should be updated to reflect that this is just adding documentation
  2. Or a new box component should be created to match the PR description

If a new box component is intended, it should be created in packages/ui-webc/src/components/box/ following the component structure conventions (with box.tsx, box.css, readme.md files).

Copilot uses AI. Check for mistakes.
@scriptcoded scriptcoded marked this pull request as draft February 20, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants