Conversation
|
❌ Deploy Preview for scouterna-ui failed.
|
There was a problem hiding this comment.
Pull request overview
This PR claims to add a "new box component" but actually only adds a documentation file (box.mdx) to the existing my-component directory. The new file is essentially a duplicate of the existing basic.mdx file with only a different title. There's a significant mismatch between the PR title/description and the actual changes.
Changes:
- Added
box.mdxdocumentation file inpackages/ui-webc/src/components/my-component/lab/
| ## Loops | ||
|
|
||
| {['a', 'b', 'c'].map(item => ( | ||
| <my-component first={item} last="!" /> | ||
| ))} | ||
|
|
||
| ## Object props | ||
|
|
||
| <my-component | ||
| first="Stencil" | ||
| middle="'Don't call me a framework'" | ||
| last="JS" | ||
| test={{ | ||
| name: 'dummy' | ||
| }} | ||
| /> |
There was a problem hiding this comment.
The new file box.mdx is almost identical to the existing basic.mdx file, with only the title being different ("Box Example" vs "Basic Example"). This appears to be duplicate documentation content that doesn't add value. If this is intended to demonstrate a box component, the content should be updated to reflect box-specific examples. Otherwise, this file should be removed.
| ## Loops | |
| {['a', 'b', 'c'].map(item => ( | |
| <my-component first={item} last="!" /> | |
| ))} | |
| ## Object props | |
| <my-component | |
| first="Stencil" | |
| middle="'Don't call me a framework'" | |
| last="JS" | |
| test={{ | |
| name: 'dummy' | |
| }} | |
| /> | |
| This page shows how to render `my-component` inside a simple "box" container | |
| using plain HTML and inline styles. You can replace the inline styles with | |
| your own CSS classes in a real application. | |
| ## Single boxed component | |
| <div | |
| style={{ | |
| border: '1px solid #ccc', | |
| padding: '1rem', | |
| borderRadius: '4px', | |
| backgroundColor: '#f9f9f9', | |
| }} | |
| > | |
| <my-component first="Boxed" middle="single" last="example" /> | |
| </div> | |
| ## Multiple components in boxes | |
| <div | |
| style={{ | |
| display: 'grid', | |
| gap: '0.75rem', | |
| }} | |
| > | |
| {['a', 'b', 'c'].map((item) => ( | |
| <div | |
| key={item} | |
| style={{ | |
| border: '1px solid #ddd', | |
| padding: '0.75rem', | |
| borderRadius: '4px', | |
| }} | |
| > | |
| <my-component first={item} middle="inside" last="box" /> | |
| </div> | |
| ))} | |
| </div> | |
| ## Box with additional props | |
| <div | |
| style={{ | |
| border: '2px dashed #999', | |
| padding: '1rem', | |
| borderRadius: '6px', | |
| }} | |
| > | |
| <my-component | |
| first="Stencil" | |
| middle="'Don't call me a framework'" | |
| last="JS" | |
| test={{ | |
| name: 'boxed example', | |
| }} | |
| /> | |
| </div> |
| @@ -0,0 +1,18 @@ | |||
| # Box Example | |||
There was a problem hiding this comment.
The PR title says "feat: new box component" but the changes only add a documentation file (box.mdx) for the existing my-component. No actual box component is being created. Either:
- The PR title should be updated to reflect that this is just adding documentation
- Or a new box component should be created to match the PR description
If a new box component is intended, it should be created in packages/ui-webc/src/components/box/ following the component structure conventions (with box.tsx, box.css, readme.md files).
test pr to see how netlify prints commetn