feat: required properties are supplied via a constructor function#52
Open
ColinEberhardt wants to merge 1 commit intomainfrom
Open
feat: required properties are supplied via a constructor function#52ColinEberhardt wants to merge 1 commit intomainfrom
ColinEberhardt wants to merge 1 commit intomainfrom
Conversation
|
Great, happy it was a sensible suggestion! Not that familiar with the code so my approving the request is meaningless but what you're doing looks sensible. Quick one just from looking at it though, have you considered using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@OiNutter based on your suggestions on this PR #50 - this is an alternative implementation where constructors are used for required properties.
The debate about interfaces / classes aside (#51), I do think this is a cleaner way to handle required properties.