[I-03] Add function to Splitter for stray token recovery#46
Merged
Conversation
alexkeating
reviewed
Apr 24, 2026
| } | ||
|
|
||
| contract Recover is SplitterTest { | ||
| function testFuzz_RecoversTokens_WhenCalledByAdmin(address _to, uint256 _amount) public { |
Collaborator
There was a problem hiding this comment.
Suggested change
| function testFuzz_RecoversTokens_WhenCalledByAdmin(address _to, uint256 _amount) public { | |
| function testFuzz_RecoversTokensWhenCalledByAdmin(address _to, uint256 _amount) public { |
Collaborator
There was a problem hiding this comment.
Remove the underscore for the rest if possible
alexkeating
reviewed
Apr 24, 2026
|
|
||
| contract Recover is SplitterTest { | ||
| function testFuzz_RecoversTokens_WhenCalledByAdmin(address _to, uint256 _amount) public { | ||
| vm.assume(_to != address(0) && _to != address(splitter)); |
Collaborator
There was a problem hiding this comment.
Do we have tests for these assume cases?
mikeghen
force-pushed
the
i-03-splitter-recover
branch
from
aee54d4 to
b62feaf
Compare
mikeghen
force-pushed
the
i-03-splitter-recover
branch
from
b62feaf to
8117cf1
Compare
|
Coverage after merging i-03-splitter-recover into main will be
Coverage Report
|
|||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #40