Skip to content

[I-02] Make safe downcast of distributor weights in deploy script #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexkeating merged 1 commit into from
Apr 30, 2026
Merged

[I-02] Make safe downcast of distributor weights in deploy script #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions script/Deploy.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {Splitter} from "src/Splitter.sol";
import {IERC20} from "lib/openzeppelin-contracts/contracts/token/ERC20/IERC20.sol";
import {IERC20Burnable} from "src/interfaces/IERC20Burnable.sol";
import {ERC1967Proxy} from "lib/openzeppelin-contracts/contracts/proxy/ERC1967/ERC1967Proxy.sol";
import {SafeCast} from "lib/openzeppelin-contracts/contracts/utils/math/SafeCast.sol";

/// @title Deploy
/// @notice Deploys FeeFlow and Splitter behind ERC1967 proxies.
Expand Down Expand Up @@ -161,8 +162,9 @@ contract Deploy is Script {
new Splitter.DistributorConfig[](_recipients.length);
for (uint256 _i; _i < _recipients.length; ++_i) {
if (_weights[_i] == 0) revert Deploy_DistributorWeightZero(_i);
_distributors[_i] =
Splitter.DistributorConfig({recipient: _recipients[_i], weight: uint96(_weights[_i])});
_distributors[_i] = Splitter.DistributorConfig({
recipient: _recipients[_i], weight: SafeCast.toUint96(_weights[_i])
});
}
return _distributors;
}
Expand Down
Loading