Skip to content

[G-01] Cache storage reads in claim to avoid redundant SLOADs #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexkeating merged 1 commit into from
Apr 30, 2026
Merged

[G-01] Cache storage reads in claim to avoid redundant SLOADs #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/FeeFlow.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,15 @@ contract FeeFlow is AccessControlUpgradeable, UUPSUpgradeable {
FeeFlowStorage storage $ = _getFeeFlowStorage();
if ($._claimPaused) revert FeeFlow_ClaimPaused();
uint256 _bidAmount = $._bidThreshold;
IERC20 _bidToken = $._bidToken;
address _destination = $._destination;

$._bidToken.safeTransferFrom(msg.sender, $._destination, _bidAmount);
ISplitter($._destination).split();
_bidToken.safeTransferFrom(msg.sender, _destination, _bidAmount);
ISplitter(_destination).split();

for (uint256 _i = 0; _i < _claimRequests.length; _i++) {
IERC20 _token = _claimRequests[_i].token;
if (_token == $._bidToken) revert FeeFlow_InvalidFeeToken();
if (_token == _bidToken) revert FeeFlow_InvalidFeeToken();
if (!$._claimableTokens[_token]) revert FeeFlow_TokenNotClaimable();
uint256 _balance = _token.balanceOf(address(this));
if (_balance == 0 || _balance < _claimRequests[_i].minAmountRequested) {
Expand Down
Loading