Bump forgestd 1.11.0 & resolve new warnings#29
Merged
thelostone-mc merged 2 commits intomainfrom Nov 10, 2025
Merged
Conversation
These changes resolve warnings on unused imports in the test file. In one case, the import of console2, we suppress the warning because it's convenient to leave console2 imported in test files even if not actively used, so it doesn't first have to be imported by the dev when debugging. Second, we change the deploy script to return the Counter rather than store it locally. This change resolves the import issue in an opinionated way: it's better for the script to be stateless anyway.
|
Coverage after merging bump-forgestd-1.11.0 into main will be
Coverage Report
|
|||||||||||||||||||
thelostone-mc
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: