tomcat10: Add version 10.1.52#2735
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughAdds a new Scoop manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. tomcat10
|
There was a problem hiding this comment.
Pull request overview
Adds a new Scoop manifest for Apache Tomcat 10 so it can be installed/managed via this bucket, including architecture-specific downloads, persistence, and update automation.
Changes:
- Added
bucket/tomcat10.jsonmanifest for Tomcat 10.1.52 (x86/x64 URLs + SHA512). - Configured
CATALINA_HOME/CATALINA_BASEenv vars and persistence forconf+webapps. - Added
checkverandautoupdatedefinitions for future version bumps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
bucket/tomcat10.json (2)
29-32: Consider a more reliablecheckversource URL.The current
checkverURL hitsarchive.apache.orgsorted by modification time (C=M;O=D). This works today, but Scoop uses only the first matching result, so correctness depends entirely on the archive server consistently honouring theC=M;O=Dquery parameter — if the sort changes or the server behaviour shifts, checkver silently picks up a stale version.The official download page (
https://tomcat.apache.org/download-10.cgi) reliably reflects the current release and wouldn't require relying on directory-listing sort order:♻️ Proposed alternative checkver
- "checkver": { - "url": "https://archive.apache.org/dist/tomcat/tomcat-10/?C=M;O=D", - "regex": "v([\\d.]+)/" - }, + "checkver": { + "url": "https://tomcat.apache.org/download-10.cgi", + "regex": "Apache Tomcat ([\\d.]+)" + },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tomcat10.json` around lines 29 - 32, Replace the fragile archive directory listing used by the "checkver" block with the official Tomcat 10 download page URL (https://tomcat.apache.org/download-10.cgi) and update the "regex" to reliably extract the current release (e.g., match sequences like 10.x.y). Specifically, in the checkver object replace the "url" value and adjust the "regex" pattern so it captures the canonical release string from the official page rather than relying on archive sorting.
25-28: Consider persistinglogsto survive Scoop upgrades.
logslives insideCATALINA_BASE($dir), which is replaced on everyscoop update. Sinceconfandwebappsare already persisted, omittinglogsmeans server logs are silently discarded on each upgrade — a notable gap for any production or long-running use.♻️ Proposed addition
"persist": [ "conf", + "logs", "webapps" ],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tomcat10.json` around lines 25 - 28, The persist array currently contains "conf" and "webapps" but not "logs", which causes Tomcat logs under CATALINA_BASE ($dir) to be lost on scoop updates; update the persist array (the "persist" JSON field) to also include "logs" alongside "conf" and "webapps" so that server logs survive upgrades and restarts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/tomcat10.json`:
- Line 3: Update the "description" field in tomcat10.json to replace the
outdated "Java EE" terminology with "Jakarta EE" and mention the correct
specs/namespaces (e.g., Servlet 6.0 and JSP 3.1 from Jakarta EE) so the
description accurately reflects Tomcat 10.1's Jakarta EE implementation; edit
the value of the "description" key accordingly.
---
Nitpick comments:
In `@bucket/tomcat10.json`:
- Around line 29-32: Replace the fragile archive directory listing used by the
"checkver" block with the official Tomcat 10 download page URL
(https://tomcat.apache.org/download-10.cgi) and update the "regex" to reliably
extract the current release (e.g., match sequences like 10.x.y). Specifically,
in the checkver object replace the "url" value and adjust the "regex" pattern so
it captures the canonical release string from the official page rather than
relying on archive sorting.
- Around line 25-28: The persist array currently contains "conf" and "webapps"
but not "logs", which causes Tomcat logs under CATALINA_BASE ($dir) to be lost
on scoop updates; update the persist array (the "persist" JSON field) to also
include "logs" alongside "conf" and "webapps" so that server logs survive
upgrades and restarts.
| @@ -0,0 +1,47 @@ | |||
| { | |||
| "version": "10.1.52", | |||
| "description": "Implementation of the Java Servlet, JavaServer Pages, Java Expression Language and Java WebSocket technologies", | |||
There was a problem hiding this comment.
Description uses outdated Java EE terminology — should be Jakarta EE.
Apache Tomcat 10.1 implements the Servlet 6.0 and Pages 3.1 specifications from Jakarta EE. The description should reflect the Jakarta namespace:
📝 Proposed fix
- "description": "Implementation of the Java Servlet, JavaServer Pages, Java Expression Language and Java WebSocket technologies",
+ "description": "Implementation of the Jakarta Servlet, Jakarta Pages, Jakarta Expression Language and Jakarta WebSocket technologies",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "description": "Implementation of the Java Servlet, JavaServer Pages, Java Expression Language and Java WebSocket technologies", | |
| "description": "Implementation of the Jakarta Servlet, Jakarta Pages, Jakarta Expression Language and Jakarta WebSocket technologies", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@bucket/tomcat10.json` at line 3, Update the "description" field in
tomcat10.json to replace the outdated "Java EE" terminology with "Jakarta EE"
and mention the correct specs/namespaces (e.g., Servlet 6.0 and JSP 3.1 from
Jakarta EE) so the description accurately reflects Tomcat 10.1's Jakarta EE
implementation; edit the value of the "description" key accordingly.
z-Fng
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. tomcat10
|
tomcat10: Add Apache Tomcat 10 manifests
This pull request adds new manifest for Apache Tomcat versions 10, enabling the installation and management through the package system. The manifest include download URLs, hash verification, environment variable setup, and auto-update support.
New Tomcat package manifest:
tomcat10.jsonmanifest for Apache Tomcat 10, supporting both 32-bit and 64-bit architectures, with versioned download URLs, hash checks, environment variable configuration, and persistence for configuration and webapps directoriestomcat10: Add tomcat10.json configuration for Apache Tomcat 10.1.52Summary by CodeRabbit