tomcat11: Add version 11.0.18#2734
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughAdds a new Tomcat 11.0.18 manifest ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. tomcat11
|
There was a problem hiding this comment.
Pull request overview
This pull request adds a new manifest file for Apache Tomcat version 11.0.18, enabling its installation and management through the Scoop package manager. The manifest follows the general structure of existing tomcat manifests but has some minor inconsistencies with established conventions in the repository.
Changes:
- Addition of
tomcat11.jsonmanifest with version 11.0.18, including download URL, SHA512 hash verification, environment variable configuration, persistence settings, and auto-update support
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
bucket/tomcat11.json (3)
25-28:checkverURL relies on archive.apache.org directory listing — may miss the latest release.The same lag risk applies here: if 11.0.18 (or any future release) isn't synced to
archive.apache.orgyet,checkverwill report the previous version as the latest. The official Apache Tomcat download page provides a more authoritative, always-current version signal.♻️ Proposed alternative using the official download page
"checkver": { - "url": "https://archive.apache.org/dist/tomcat/tomcat-11/?C=M;O=D", - "regex": "v([\\d.]+)/" + "url": "https://tomcat.apache.org/download-11.cgi", + "regex": "Apache Tomcat (11\\.[\\d.]+)" },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tomcat11.json` around lines 25 - 28, The checkver block currently uses the archive mirror URL which can lag; update the "checkver"."url" to the official Apache Tomcat 11 download page (e.g., the tomcat.apache.org download-11 page) and adjust the "checkver"."regex" to match the canonical version string on that page (for example a pattern that captures semantic versions like 11.x.y), so the checkver uses the authoritative source; locate the checkver object in tomcat11.json and replace the url and regex values accordingly (symbols: "checkver", "url", "regex").
16-16: Onlycatalina.batis exposed;startup.batandshutdown.batare not in PATH.The common Tomcat operational scripts (
startup.bat,shutdown.bat,version.bat) are inaccessible via PATH after install. This is consistent withtomcat8.jsonandtomcat9.jsonin this bucket, but users will need to prepend the full path to invoke them. Consider exposing the fullbindirectory viaenv_add_pathinstead:♻️ Proposed change to add the bin directory to PATH
- "bin": "bin\\catalina.bat", + "env_add_path": "bin",This puts all Tomcat scripts (
startup.bat,shutdown.bat,catalina.bat,version.bat) on the user's PATH without singling out just one.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tomcat11.json` at line 16, The JSON currently exposes only "bin": "bin\\catalina.bat", which hides other useful scripts; change the configuration to add the full bin directory to the PATH (use env_add_path or equivalent) so the entire bin folder (containing startup.bat, shutdown.bat, version.bat, catalina.bat) is available. Locate the "bin": "bin\\catalina.bat" entry in tomcat11.json and replace or augment it by adding an env_add_path entry that points to the bin directory (e.g., "bin" or "bin\\") rather than a single file, ensuring all Tomcat scripts are on PATH.
21-24:logsdirectory is not persisted — Tomcat logs are wiped on everyscoop update.
confandwebappsare correctly persisted for user-managed state, but omittinglogsmeans diagnostic history is lost across version updates.♻️ Proposed change to persist logs
"persist": [ "conf", + "logs", "webapps" ],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tomcat11.json` around lines 21 - 24, The persist configuration in tomcat11.json currently lists "conf" and "webapps" but omits the Tomcat "logs" directory, causing logs to be wiped on updates; update the "persist" array (the JSON key "persist" in tomcat11.json) to include "logs" alongside "conf" and "webapps" so Tomcat's log directory is retained across scoop updates.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@bucket/tomcat11.json`:
- Around line 25-28: The checkver block currently uses the archive mirror URL
which can lag; update the "checkver"."url" to the official Apache Tomcat 11
download page (e.g., the tomcat.apache.org download-11 page) and adjust the
"checkver"."regex" to match the canonical version string on that page (for
example a pattern that captures semantic versions like 11.x.y), so the checkver
uses the authoritative source; locate the checkver object in tomcat11.json and
replace the url and regex values accordingly (symbols: "checkver", "url",
"regex").
- Line 16: The JSON currently exposes only "bin": "bin\\catalina.bat", which
hides other useful scripts; change the configuration to add the full bin
directory to the PATH (use env_add_path or equivalent) so the entire bin folder
(containing startup.bat, shutdown.bat, version.bat, catalina.bat) is available.
Locate the "bin": "bin\\catalina.bat" entry in tomcat11.json and replace or
augment it by adding an env_add_path entry that points to the bin directory
(e.g., "bin" or "bin\\") rather than a single file, ensuring all Tomcat scripts
are on PATH.
- Around line 21-24: The persist configuration in tomcat11.json currently lists
"conf" and "webapps" but omits the Tomcat "logs" directory, causing logs to be
wiped on updates; update the "persist" array (the JSON key "persist" in
tomcat11.json) to include "logs" alongside "conf" and "webapps" so Tomcat's log
directory is retained across scoop updates.
z-Fng
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. tomcat11
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
bucket/tomcat11.json (2)
21-24: Consider persistinglogsto preserve log history across updatesWithout
logsin the persist list, Tomcat's log directory is removed on everyscoop update, which loses historical log data. This is a common inclusion in Tomcat Scoop manifests.♻️ Proposed addition
"persist": [ "conf", + "logs", "webapps" ],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tomcat11.json` around lines 21 - 24, The persist array in tomcat11.json currently contains "conf" and "webapps" but omits "logs", which causes Tomcat logs to be wiped on updates; update the "persist" array (the JSON key "persist" in tomcat11.json) to include "logs" alongside "conf" and "webapps" so the Tomcat log directory is preserved across scoop updates.
9-13: Consider adding 32-bit (x86) architecture for consistency with sibling manifestsThe existing
tomcat9.jsonmanifest in this repository includes both 64-bit and 32-bit (x86) architecture entries. If Apache still publishes an x86 Windows ZIP for 11.0.18, omitting it diverges from the established pattern.♻️ Proposed addition
"architecture": { "64bit": { "url": "https://archive.apache.org/dist/tomcat/tomcat-11/v11.0.18/bin/apache-tomcat-11.0.18-windows-x64.zip", "hash": "sha512:ec0f53a87ee109ae1c4c34592c39791f0b590148ce2c4a9584decb56c2aaa7178bba5e94e6ce2dc4a22995fb15a2e3aacc62623ed79b8eae78109421b5366ba2" - } + }, + "32bit": { + "url": "https://archive.apache.org/dist/tomcat/tomcat-11/v11.0.18/bin/apache-tomcat-11.0.18-windows-x86.zip", + "hash": "sha512:<sha512-of-x86-zip>" + } },And add the corresponding autoupdate URL:
"autoupdate": { "architecture": { "64bit": { "url": "https://archive.apache.org/dist/tomcat/tomcat-$majorVersion/v$version/bin/apache-tomcat-$version-windows-x64.zip" - } + }, + "32bit": { + "url": "https://archive.apache.org/dist/tomcat/tomcat-$majorVersion/v$version/bin/apache-tomcat-$version-windows-x86.zip" + } },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tomcat11.json` around lines 9 - 13, The manifest's "architecture" object only contains a "64bit" entry; add a "32bit" (x86) sibling with the corresponding Windows x86 ZIP "url" and "hash" fields to match sibling manifests (e.g., tomcat9.json) and update the autoupdate section to include the x86 download URL pattern; locate the "architecture" object and the "64bit" entry in tomcat11.json and mirror its structure to create a "32bit" entry with the correct apache-tomcat-11.0.18-windows-x86.zip URL and sha512 hash, and ensure autoupdate supports both "64bit" and "32bit".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/tomcat11.json`:
- Line 3: The description value for the tomcat11.json manifest contains a typo
"technologiesv." — update the "description" property (the JSON key "description"
in tomcat11.json) to read "Implementation of the Java Servlet, JavaServer Pages,
Java Expression Language and Java WebSocket technologies. (version 11)" by
removing the stray "v" before the period.
---
Nitpick comments:
In `@bucket/tomcat11.json`:
- Around line 21-24: The persist array in tomcat11.json currently contains
"conf" and "webapps" but omits "logs", which causes Tomcat logs to be wiped on
updates; update the "persist" array (the JSON key "persist" in tomcat11.json) to
include "logs" alongside "conf" and "webapps" so the Tomcat log directory is
preserved across scoop updates.
- Around line 9-13: The manifest's "architecture" object only contains a "64bit"
entry; add a "32bit" (x86) sibling with the corresponding Windows x86 ZIP "url"
and "hash" fields to match sibling manifests (e.g., tomcat9.json) and update the
autoupdate section to include the x86 download URL pattern; locate the
"architecture" object and the "64bit" entry in tomcat11.json and mirror its
structure to create a "32bit" entry with the correct
apache-tomcat-11.0.18-windows-x86.zip URL and sha512 hash, and ensure autoupdate
supports both "64bit" and "32bit".
tomcat11: Add Apache Tomcat and 11 manifests
This pull request adds new manifest for Apache Tomcat version 11, enabling the installation and management through the package system. The manifest include download URLs, hash verification, environment variable setup, and auto-update support.
New Tomcat package manifest:
tomcat11.jsonmanifest for Apache Tomcat 11, supporting 64-bit architecture, with similar features as above, including auto-update configuration and environment setuptomcat11: Add tomcat11.json configuration for Apache Tomcat 11.0.18Summary by CodeRabbit