zed-pre: Add version 0.228.0#2702
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new Scoop package manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with Invalid manifests
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@bucket/zed-preview.json`:
- Around line 23-28: The shortcut target in the JSON has to match the executable
location: update the "shortcuts" entry that currently references "zed.exe" to
"bin\\zed.exe" so it aligns with the "bin" field; apply the same fix in the
other manifests mentioned (zed-nightly.json and zed-opengl-nightly.json) by
ensuring each shortcuts array entry points to "bin\\zed.exe".
- Around line 1-47: The shortcut target in the "shortcuts" array points to
"zed.exe" but the package "bin" entry is "bin\\zed.exe", so update the shortcut
target to match the installed executable path; modify the "shortcuts" entry
referencing "zed.exe" to "bin\\zed.exe" (ensure the string exactly matches the
"bin" value) so the shortcut launches the correct executable after installation.
ca86959 to
48899c7
Compare
|
/verify |
|
All changes look good. Wait for review from human collaborators. zed-preview
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. zed-pre
|
Closes #2701
Relates to deevus/zed-windows-builds#50 — the current packager for
zed-nightly.Since upstream Zed provides official preview builds, I think it seems reasonable to have them here (vs the unofficial
zed-nightlybuilds that are currently in this bucket).As far as I can tell, there is no easy way to install Zed preview versions via scoop currently, so I decided to add it myself.
Upstream still doesn't provide official nightly builds for download, so the current
nightlypackages may still be valuable to some users, but personally I'd prefer to get my builds from the original packager, which this change does.Manifest is mostly copied from https://github.com/ScoopInstaller/Extras/blob/master/bucket/zed.json
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit