Skip to content

ipatool: Add version 2.3.0#7705

Merged
z-Fng merged 2 commits intoScoopInstaller:masterfrom
eugenesvk:fr-ipatool
Mar 3, 2026
Merged

ipatool: Add version 2.3.0#7705
z-Fng merged 2 commits intoScoopInstaller:masterfrom
eugenesvk:fr-ipatool

Conversation

@eugenesvk
Copy link
Contributor

Closes #7704

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

Invalid manifests

  • ipatool

Check the full log for details.

@eugenesvk
Copy link
Contributor Author

I see GITHUB API RATE LIMIT as the cause of check failure

@z-Fng
Copy link
Member

z-Fng commented Mar 3, 2026

I see GITHUB API RATE LIMIT as the cause of check failure

This is a json schema validation error, not a GitHub rate limiting issue.

Property 'architecture' is not allowed for 'hash'.
Property 'architecture' has not been defined and the schema does not allow additional properties

@eugenesvk
Copy link
Contributor Author

eugenesvk commented Mar 3, 2026

Where do you see this error? And why did local checks/manifest autoformatting and app updates not catch it? Where did the update get the hash from then?

But more importantly, how do you check hashes if they're in different per-architecture files? Or did the tool just ignore that value and those custom files and calculated hash from github itself?

@eugenesvk
Copy link
Contributor Author

It seems it's not needed indeed, guess it's auto-calculated from github, so I've just removed the hash key

@z-Fng z-Fng changed the title ipatool: Add version 2.3.0 (#7704) ipatool: Add version 2.3.0 Mar 3, 2026
@z-Fng
Copy link
Member

z-Fng commented Mar 3, 2026

Where do you see this error?

From the CI logs and the VSCode JSON plugin.
https://github.com/ScoopInstaller/Main/actions/runs/22613032209/job/65519295815
image

But more importantly, how do you check hashes if they're in different per-architecture files? Or did the tool just ignore that value and those custom files and calculated hash from github itself?

If necessary, the hash field should be nested under the architecture field, not the other way around.

"autoupdate": {
"architecture": {
"64bit": {
"url": "https://dl.influxdata.com/chronograf/releases/chronograf-$version_windows_amd64.zip",
"hash": {
"url": "https://portal.influxdata.com/downloads/",
"regex": "$sha256.*\\s.*$basename"
},
"extract_dir": "chronograf-$version-1"
}
}
}

@eugenesvk
Copy link
Contributor Author

I see, thanks, I was only checking the links that the bot mentioned as failing, wonder why it didn't link to the logs you did.

@z-Fng
Copy link
Member

z-Fng commented Mar 3, 2026

I was only checking the links that the bot mentioned as failing, wonder why it didn't link to the logs you did.

The log output is a bit of a mess.

@z-Fng
Copy link
Member

z-Fng commented Mar 3, 2026

/verify

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

#7705 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

All changes look good.

Wait for review from human collaborators.

ipatool

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit a1d4d53 into ScoopInstaller:master Mar 3, 2026
3 checks passed
@eugenesvk eugenesvk deleted the fr-ipatool branch March 3, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: ipatool

2 participants