Skip to content

tsukimi: Update to version 26.5.3, enable checkver, fix autoupdate#17862

Merged
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
ccyykkcyk:tsukimi
May 23, 2026
Merged

tsukimi: Update to version 26.5.3, enable checkver, fix autoupdate#17862
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
ccyykkcyk:tsukimi

Conversation

@ccyykkcyk
Copy link
Copy Markdown
Contributor

@ccyykkcyk ccyykkcyk commented May 23, 2026

Relates to #16741

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request updates the bucket/tsukimi.json manifest to version 26.5.3, switches the Windows x86_64 artifact to the ucrt64 variant and replaces the sha512-prefixed hash with an unprefixed sha256 digest, removes upstream Windows notes, and reconfigures autoupdate to use checkver: "github" with an updated architecture-specific URL template (autoupdate.hash removed).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • ScoopInstaller/Extras#16741: Modifies bucket/tsukimi.json around checkver and Windows packaging guidance; touches the same manifest fields and notes.
  • ScoopInstaller/Extras#16447: Converts a manifest to architecture-specific GitHub asset URLs and asset-derived hash handling, similar autoupdate/checkver changes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed PR description references issue #16741 and confirms both required checklist items (conventional title and Contributing Guide review).
Title check ✅ Passed The title accurately and concisely summarizes the main changes: updating Tsukimi to version 26.5.3 and enabling/fixing checkver and autoupdate logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/tsukimi.json (1)

21-31: Please run manifest validation steps before merge.

Recommended local checks for this manifest (tsukimi):

  • scoop config debug true
  • scoop config gh_token <your-github-token> (read-only, optional)
  • .\bin\checkver.ps1 -App tsukimi -f
  • .\bin\formatjson.ps1 -App tsukimi
  • scoop install .\bucket\tsukimi.json -a 64bit

If anything is unclear, refer to:

As per coding guidelines, "Provide clear instructions for testing the manifest locally before submission."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/tsukimi.json` around lines 21 - 31, The manifest tsukimi
(tsukimi.json) needs local validation before merge: run the Scoop manifest
checks and install test by enabling debug and (optionally) a GitHub token, then
run .\bin\checkver.ps1 -App tsukimi -f to validate checkver,
.\bin\formatjson.ps1 -App tsukimi to format/validate JSON and finally attempt
installation with scoop install .\bucket\tsukimi.json -a 64bit to verify the
autoupdate/url and hash fields work as expected; update any failures in the
"checkver" or "autoupdate" sections accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/tsukimi.json`:
- Around line 21-31: The manifest tsukimi (tsukimi.json) needs local validation
before merge: run the Scoop manifest checks and install test by enabling debug
and (optionally) a GitHub token, then run .\bin\checkver.ps1 -App tsukimi -f to
validate checkver, .\bin\formatjson.ps1 -App tsukimi to format/validate JSON and
finally attempt installation with scoop install .\bucket\tsukimi.json -a 64bit
to verify the autoupdate/url and hash fields work as expected; update any
failures in the "checkver" or "autoupdate" sections accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2253b842-1e11-4a06-a9bb-21961ac12590

📥 Commits

Reviewing files that changed from the base of the PR and between b41b204 and a0341bf.

📒 Files selected for processing (1)
  • bucket/tsukimi.json

@ccyykkcyk
Copy link
Copy Markdown
Contributor Author

/verify

@github-actions
Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

tsukimi

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@ccyykkcyk
Copy link
Copy Markdown
Contributor Author

/verify

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

tsukimi

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/tsukimi.json (1)

1-29: Testing guidance for this manifest.

Before merging, please test the manifest locally following these steps:

  1. Optional: Enable debug mode and set GitHub token (for GitHub API access):

    scoop config debug true
    scoop config gh_token <your-github-token>  # Read access only
  2. Force version detection and autoupdate:

    .\bin\checkver.ps1 -App tsukimi -f
  3. Auto-format (Lint) the JSON manifest:

    .\bin\formatjson.ps1 -App tsukimi
  4. Test installation:

    scoop install bucket\tsukimi.json -a 64bit
  5. Verify the application launches correctly and test basic functionality.

For any questions or issues, please refer to:

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/tsukimi.json` around lines 1 - 29, The manifest tsukimi.json needs
local verification before merge: run the suggested steps—enable debug and set
gh_token if needed, run .\bin\checkver.ps1 -App tsukimi -f to force version
detection for the "checkver"/autoupdate blocks, run .\bin\formatjson.ps1 -App
tsukimi to lint the JSON, then test installation with scoop install
bucket\tsukimi.json -a 64bit and verify the shortcut ("shortcuts" ->
"bin\\tsukimi.exe") launches the app; after completing these steps, update the
PR description with confirmation and any fixes (e.g., correct
"architecture"/"autoupdate" URLs or checksum) so reviewers know the manifest and
installation work locally.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/tsukimi.json`:
- Around line 1-29: The manifest tsukimi.json needs local verification before
merge: run the suggested steps—enable debug and set gh_token if needed, run
.\bin\checkver.ps1 -App tsukimi -f to force version detection for the
"checkver"/autoupdate blocks, run .\bin\formatjson.ps1 -App tsukimi to lint the
JSON, then test installation with scoop install bucket\tsukimi.json -a 64bit and
verify the shortcut ("shortcuts" -> "bin\\tsukimi.exe") launches the app; after
completing these steps, update the PR description with confirmation and any
fixes (e.g., correct "architecture"/"autoupdate" URLs or checksum) so reviewers
know the manifest and installation work locally.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8ae1a37e-308c-4b6e-97d0-b62c6c5d8faa

📥 Commits

Reviewing files that changed from the base of the PR and between a0341bf and 912d45c.

📒 Files selected for processing (1)
  • bucket/tsukimi.json

@z-Fng z-Fng changed the title tsukimi: Update to version 26.5.3, fix checkver & autoupdate tsukimi: Update to version 26.5.3, enable checkver, fix autoupdate May 23, 2026
Copy link
Copy Markdown
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng
Copy link
Copy Markdown
Member

z-Fng commented May 23, 2026

cc: @SorYoshino

@z-Fng z-Fng merged commit df256fb into ScoopInstaller:master May 23, 2026
3 checks passed
@ccyykkcyk ccyykkcyk deleted the tsukimi branch May 23, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants