tsukimi: Update to version 26.5.3, enable checkver, fix autoupdate#17862
Conversation
📝 WalkthroughWalkthroughThis pull request updates the bucket/tsukimi.json manifest to version 26.5.3, switches the Windows x86_64 artifact to the ucrt64 variant and replaces the sha512-prefixed hash with an unprefixed sha256 digest, removes upstream Windows notes, and reconfigures autoupdate to use checkver: "github" with an updated architecture-specific URL template (autoupdate.hash removed). Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/tsukimi.json (1)
21-31: Please run manifest validation steps before merge.Recommended local checks for this manifest (
tsukimi):
scoop config debug truescoop config gh_token <your-github-token>(read-only, optional).\bin\checkver.ps1 -App tsukimi -f.\bin\formatjson.ps1 -App tsukimiscoop install .\bucket\tsukimi.json -a 64bitIf anything is unclear, refer to:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/tsukimi.json` around lines 21 - 31, The manifest tsukimi (tsukimi.json) needs local validation before merge: run the Scoop manifest checks and install test by enabling debug and (optionally) a GitHub token, then run .\bin\checkver.ps1 -App tsukimi -f to validate checkver, .\bin\formatjson.ps1 -App tsukimi to format/validate JSON and finally attempt installation with scoop install .\bucket\tsukimi.json -a 64bit to verify the autoupdate/url and hash fields work as expected; update any failures in the "checkver" or "autoupdate" sections accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/tsukimi.json`:
- Around line 21-31: The manifest tsukimi (tsukimi.json) needs local validation
before merge: run the Scoop manifest checks and install test by enabling debug
and (optionally) a GitHub token, then run .\bin\checkver.ps1 -App tsukimi -f to
validate checkver, .\bin\formatjson.ps1 -App tsukimi to format/validate JSON and
finally attempt installation with scoop install .\bucket\tsukimi.json -a 64bit
to verify the autoupdate/url and hash fields work as expected; update any
failures in the "checkver" or "autoupdate" sections accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2253b842-1e11-4a06-a9bb-21961ac12590
📒 Files selected for processing (1)
bucket/tsukimi.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with tsukimi
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. tsukimi
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/tsukimi.json (1)
1-29: Testing guidance for this manifest.Before merging, please test the manifest locally following these steps:
Optional: Enable debug mode and set GitHub token (for GitHub API access):
scoop config debug true scoop config gh_token <your-github-token> # Read access onlyForce version detection and autoupdate:
.\bin\checkver.ps1 -App tsukimi -fAuto-format (Lint) the JSON manifest:
.\bin\formatjson.ps1 -App tsukimiTest installation:
scoop install bucket\tsukimi.json -a 64bitVerify the application launches correctly and test basic functionality.
For any questions or issues, please refer to:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/tsukimi.json` around lines 1 - 29, The manifest tsukimi.json needs local verification before merge: run the suggested steps—enable debug and set gh_token if needed, run .\bin\checkver.ps1 -App tsukimi -f to force version detection for the "checkver"/autoupdate blocks, run .\bin\formatjson.ps1 -App tsukimi to lint the JSON, then test installation with scoop install bucket\tsukimi.json -a 64bit and verify the shortcut ("shortcuts" -> "bin\\tsukimi.exe") launches the app; after completing these steps, update the PR description with confirmation and any fixes (e.g., correct "architecture"/"autoupdate" URLs or checksum) so reviewers know the manifest and installation work locally.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/tsukimi.json`:
- Around line 1-29: The manifest tsukimi.json needs local verification before
merge: run the suggested steps—enable debug and set gh_token if needed, run
.\bin\checkver.ps1 -App tsukimi -f to force version detection for the
"checkver"/autoupdate blocks, run .\bin\formatjson.ps1 -App tsukimi to lint the
JSON, then test installation with scoop install bucket\tsukimi.json -a 64bit and
verify the shortcut ("shortcuts" -> "bin\\tsukimi.exe") launches the app; after
completing these steps, update the PR description with confirmation and any
fixes (e.g., correct "architecture"/"autoupdate" URLs or checksum) so reviewers
know the manifest and installation work locally.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8ae1a37e-308c-4b6e-97d0-b62c6c5d8faa
📒 Files selected for processing (1)
bucket/tsukimi.json
|
cc: @SorYoshino |
Relates to #16741
<manifest-name[@version]|chore>: <general summary of the pull request>