libation: Add version 13.4.3#17861
Open
ranclo wants to merge 2 commits into
Open
Conversation
📝 WalkthroughWalkthroughA new Scoop package manifest for Libation 13.4.3 is added to the Extras bucket. The manifest includes version metadata, x64 and arm64 download URLs with SHA-1 integrity hashes, a PowerShell pre-install script that creates Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
libation.json (1)
1-38: Please run the standard local manifest checks before submission.Suggested commands for this manifest (
libation):scoop config debug true scoop config gh_token <your-github-token> # Read access only .\bin\checkver.ps1 -App libation -f .\bin\formatjson.ps1 -App libation scoop install bucket/libation.json -a 64bit scoop install bucket/libation.json -a arm64If placement remains outside
bucket/, adjust the install path accordingly during local testing.
References:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, "
Provide clear instructions for testing the manifest locally before submission."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@libation.json` around lines 1 - 38, Run the standard local manifest checks for the libation manifest: enable debug (scoop config debug true) and set a read-only GH token, then run the checkver and formatter (use .\bin\checkver.ps1 -App libation -f and .\bin\formatjson.ps1 -App libation) and attempt installs for both architectures (scoop install bucket/libation.json -a 64bit and -a arm64); if your manifest is not under bucket/ adjust the install path accordingly and confirm pre_install, checkver, autoupdate and architecture entries behave as expected during these tests.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@libation.json`:
- Line 1: The manifest file libation.json is in the repo root but must be
located inside the Scoop bucket; move libation.json into the required directory
(either bucket/ or deprecated/) so it lives at bucket/libation.json (or
deprecated/libation.json) and update any references if present; ensure the file
path now passes the "Path Check" rule requiring manifests to be strictly within
bucket/ or deprecated/.
---
Nitpick comments:
In `@libation.json`:
- Around line 1-38: Run the standard local manifest checks for the libation
manifest: enable debug (scoop config debug true) and set a read-only GH token,
then run the checkver and formatter (use .\bin\checkver.ps1 -App libation -f and
.\bin\formatjson.ps1 -App libation) and attempt installs for both architectures
(scoop install bucket/libation.json -a 64bit and -a arm64); if your manifest is
not under bucket/ adjust the install path accordingly and confirm pre_install,
checkver, autoupdate and architecture entries behave as expected during these
tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fd4c0133-42db-41a0-b15c-d9362eceb5f5
📒 Files selected for processing (1)
libation.json
Contributor
Author
|
/verify |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/libation.json (1)
1-38: Run local Scoop validation before merge.Please verify the manifest locally with:
scoop config debug true scoop config gh_token <your-github-token> # Read access only .\bin\checkver.ps1 -App libation -f .\bin\formatjson.ps1 -App libation scoop install bucket/libation.json -a 64bit scoop install bucket/libation.json -a arm64Helpful references:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/libation.json` around lines 1 - 38, Run the local Scoop manifest validation and install tests for the libation manifest: set scoop debug and a read-only GitHub token, then execute .\bin\checkver.ps1 -App libation -f and .\bin\formatjson.ps1 -App libation to validate and format the manifest (verify checkver and autoupdate entries), and finally run scoop install bucket/libation.json -a 64bit and scoop install bucket/libation.json -a arm64 to ensure pre_install, bin (LibationCli.exe), persist (appsettings.json) and shortcuts work correctly; fix any issues the scripts report (missing fields, URL/hash mismatches, or pre_install path problems) and re-run until clean.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/libation.json`:
- Around line 1-38: Run the local Scoop manifest validation and install tests
for the libation manifest: set scoop debug and a read-only GitHub token, then
execute .\bin\checkver.ps1 -App libation -f and .\bin\formatjson.ps1 -App
libation to validate and format the manifest (verify checkver and autoupdate
entries), and finally run scoop install bucket/libation.json -a 64bit and scoop
install bucket/libation.json -a arm64 to ensure pre_install, bin
(LibationCli.exe), persist (appsettings.json) and shortcuts work correctly; fix
any issues the scripts report (missing fields, URL/hash mismatches, or
pre_install path problems) and re-run until clean.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f398c61f-837c-4d31-8d15-66604acaebcb
📒 Files selected for processing (1)
bucket/libation.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17860
<manifest-name[@version]|chore>: <general summary of the pull request>