Skip to content

android-performance-analyzer: Add version 0.8.0-RC3#17857

Open
Vixb1122 wants to merge 1 commit into
ScoopInstaller:masterfrom
Vixb1122:android-performance-analyzer
Open

android-performance-analyzer: Add version 0.8.0-RC3#17857
Vixb1122 wants to merge 1 commit into
ScoopInstaller:masterfrom
Vixb1122:android-performance-analyzer

Conversation

@Vixb1122
Copy link
Copy Markdown
Contributor

Closes #17856

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a new Scoop bucket manifest file for Android Performance Analyzer, a performance profiling tool for Android applications. The manifest defines package metadata (description, homepage, freeware license), specifies the 64-bit Windows download URL with SHA-256 hash validation, configures extraction to the apa-windows directory with a desktop shortcut, and includes version detection and autoupdate rules to automatically update download URLs and hashes when new versions are released.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding version 0.8.0-RC3 of the android-performance-analyzer package.
Description check ✅ Passed The PR description meets the template requirements by referencing the linked issue, using the conventional PR title format, and confirming the contributor has read the Contributing Guide.
Linked Issues check ✅ Passed The changes fully satisfy the requirements from issue #17856 by adding the Android Performance Analyzer manifest with the correct version, homepage, and download URL specified.
Out of Scope Changes check ✅ Passed All changes are in scope; the single file modification adds only the requested android-performance-analyzer package manifest with no unrelated alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/android-performance-analyzer.json (1)

1-34: Testing instructions for this manifest.

Before this manifest can be merged, please test it locally using the following commands:

1. Auto-format the manifest:

.\bin\formatjson.ps1 -App android-performance-analyzer

2. Test checkver and autoupdate (optional but recommended):

# Optional: Enable debug mode for verbose output
scoop config debug true

# Optional: Set GitHub token for API access (read-only)
scoop config gh_token <your-github-token>

# Force version detection and autoupdate
.\bin\checkver.ps1 -App android-performance-analyzer -f

3. Test installation:

scoop install .\bucket\android-performance-analyzer.json -a 64bit

4. Verify the shortcut and binary work:

  • Check that the Start Menu shortcut "Android Performance Analyzer" is created
  • Launch the application to ensure it runs properly
  • Test basic functionality

For more guidance, see:

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/android-performance-analyzer.json` around lines 1 - 34, Add a short
QA/testing checklist to the PR and locally verify the manifest by running the
formatter and updater and confirming the shortcut/binary: run
.\bin\formatjson.ps1 -App android-performance-analyzer, optionally enable debug
and set gh_token then run .\bin\checkver.ps1 -App android-performance-analyzer
-f to validate checkver/autoupdate, install with scoop install
.\bucket\android-performance-analyzer.json -a 64bit, and confirm the Start Menu
shortcut named "Android Performance Analyzer" points to the binary listed in the
manifest (bin\apa64.exe) and that the app launches; if the shortcut path or
extract_dir ("apa-windows") is incorrect, update the "shortcuts" entry or
"extract_dir" in android-performance-analyzer.json accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/android-performance-analyzer.json`:
- Line 2: The package uses a pre-release version string "0.8.0-RC3" in the JSON
"version" field which violates the acceptance criteria; update the "version"
field from the release-candidate value to the official stable/GA version once
available (replace "0.8.0-RC3" with the GA version), or if no stable release
exists yet, withdraw or mark the package submission as draft and do not add the
package until a non-pre-release version is published.

---

Nitpick comments:
In `@bucket/android-performance-analyzer.json`:
- Around line 1-34: Add a short QA/testing checklist to the PR and locally
verify the manifest by running the formatter and updater and confirming the
shortcut/binary: run .\bin\formatjson.ps1 -App android-performance-analyzer,
optionally enable debug and set gh_token then run .\bin\checkver.ps1 -App
android-performance-analyzer -f to validate checkver/autoupdate, install with
scoop install .\bucket\android-performance-analyzer.json -a 64bit, and confirm
the Start Menu shortcut named "Android Performance Analyzer" points to the
binary listed in the manifest (bin\apa64.exe) and that the app launches; if the
shortcut path or extract_dir ("apa-windows") is incorrect, update the
"shortcuts" entry or "extract_dir" in android-performance-analyzer.json
accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eca7da41-c320-4725-8e3f-183e107d040a

📥 Commits

Reviewing files that changed from the base of the PR and between b3016b7 and 06b9c6b.

📒 Files selected for processing (1)
  • bucket/android-performance-analyzer.json

@@ -0,0 +1,34 @@
{
"version": "0.8.0-RC3",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

RC version violates acceptance criteria for new packages.

The version 0.8.0-RC3 is a Release Candidate, which is a pre-release version. According to the acceptance criteria for new package requests, packages must have "a stable release available (not in pre-release or alpha stage)."

Please wait for a stable/GA (General Availability) release of Android Performance Analyzer before submitting this package to the Extras bucket.

As per coding guidelines: "Acceptance criteria for new package requests: A stable release available (not in pre-release or alpha stage)."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/android-performance-analyzer.json` at line 2, The package uses a
pre-release version string "0.8.0-RC3" in the JSON "version" field which
violates the acceptance criteria; update the "version" field from the
release-candidate value to the official stable/GA version once available
(replace "0.8.0-RC3" with the GA version), or if no stable release exists yet,
withdraw or mark the package submission as draft and do not add the package
until a non-pre-release version is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Android Performance Analyzer

1 participant