lfk: Add version 0.12.0#17822
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds bucket/lfk.json, a Scoop package manifest for lfk v0.12.0. The manifest lists architecture-specific download URLs and SHA-256 checksums for Windows AMD64 and ARM64, sets the installed binary to lfk.exe, configures env_set mappings for config/state/data under $persist_dir, and includes checkver and autoupdate templating to discover future versions and their checksums. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
the
package-request-needed
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/lfk.json (1)
22-36: Run the standard local manifest validation flow before merge.Use the repo’s manifest test flow for this app:
scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App lfk -f .\bin\formatjson.ps1 -App lfk scoop install .\bucket\lfk.json -a 64bit scoop install .\bucket\lfk.json -a arm64As per coding guidelines "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/lfk.json` around lines 22 - 36, Run the repository’s standard local manifest validation flow for the lfk manifest: enable Scoop debug and set GH token, then run the checkver and formatjson scripts for App "lfk" (using .\bin\checkver.ps1 -App lfk -f and .\bin\formatjson.ps1 -App lfk) and validate installs for both architectures (scoop install the manifest for 64bit and arm64). While doing this, verify the autoupdate keys—specifically "checkver", "autoupdate.architecture" URL templates and "autoupdate.hash.regex"—expand correctly (version substitution into the URLs and correct checksum lookup in checksums.txt) and fix any formatting/regex issues so the manifest passes the local validation and installs for both architectures.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/lfk.json`:
- Line 3: Update the new manifest's description to include a linked
package-request issue (e.g., append "See package-request: `#123`" or a full issue
URL) or add that issue link to the PR body; modify the "description" value in
lfk.json (the "description" field) to include the package-request reference and
also ensure the PR references the contribution guide links provided in the
reviewer comment (optional: include the two URLs in PR body if you prefer not to
alter the description).
---
Nitpick comments:
In `@bucket/lfk.json`:
- Around line 22-36: Run the repository’s standard local manifest validation
flow for the lfk manifest: enable Scoop debug and set GH token, then run the
checkver and formatjson scripts for App "lfk" (using .\bin\checkver.ps1 -App lfk
-f and .\bin\formatjson.ps1 -App lfk) and validate installs for both
architectures (scoop install the manifest for 64bit and arm64). While doing
this, verify the autoupdate keys—specifically "checkver",
"autoupdate.architecture" URL templates and "autoupdate.hash.regex"—expand
correctly (version substitution into the URLs and correct checksum lookup in
checksums.txt) and fix any formatting/regex issues so the manifest passes the
local validation and installs for both architectures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1d76752c-c4a0-440a-a820-0d993743ce1d
📒 Files selected for processing (1)
bucket/lfk.json
| @@ -0,0 +1,37 @@ | |||
| { | |||
| "version": "0.12.0", | |||
| "description": "Lightning Fast Kubernetes navigator - keyboard-focused TUI for managing K8s clusters", | |||
There was a problem hiding this comment.
Link a package-request issue for this new manifest.
This is a newly added manifest, but the provided PR description does not include a package-request issue reference (#123 or issue URL). Please add one in the manifest description or PR body:
https://github.com/ScoopInstaller/Extras/issues/new?labels=package-request&template=package-request.yml&title=%5BRequest%5D%3A+
Also see:
https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines "If this is a NEWLY ADDED manifest file ... check the description field or the PR body for a linked GitHub issue" and "For any violations ... always provide a link to the official contribution guide or wiki."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/lfk.json` at line 3, Update the new manifest's description to include
a linked package-request issue (e.g., append "See package-request: `#123`" or a
full issue URL) or add that issue link to the PR body; modify the "description"
value in lfk.json (the "description" field) to include the package-request
reference and also ensure the PR references the contribution guide links
provided in the reviewer comment (optional: include the two URLs in PR body if
you prefer not to alter the description).
|
Package request issue: |
|
/verify |
|
All changes look good. Wait for review from human collaborators. lfk
|
coderabbitai
Bot
removed
the
package-request-needed
1 participant
Adds a Scoop manifest for lfk — a keyboard-focused Kubernetes TUI (Apache-2.0, Go).
env_setpointsLFK_CONFIG_DIR/LFK_STATE_DIR/LFK_DATA_DIRat$persist_dir, so config, state, and logs persist across updates.Closes #17823
<manifest-name[@version]|chore>: <general summary of the pull request>