FancyWM: Add version 2.19.0#17758
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded a new manifest file Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/fancywm.json (1)
1-38: Local validation checklist before merge (recommended).To validate installability and autoupdate behavior for
fancywm, please run:
scoop config debug truescoop config gh_token <your-github-token>.\bin\checkver.ps1 -App fancywm -f.\bin\formatjson.ps1 -App fancywmscoop install .\bucket\fancywm.json -a 64bitAs per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/fancywm.json` around lines 1 - 38, The PR is missing the recommended local validation steps for the fancywm manifest; add a brief "Testing" or "Local validation" section either to the PR description or as a comment near the top of fancywm.json that lists the exact commands to run: enable debug and set GH token (scoop config debug true; scoop config gh_token <your-github-token>), run .\bin\checkver.ps1 -App fancywm -f, run .\bin\formatjson.ps1 -App fancywm, and install locally with scoop install .\bucket\fancywm.json -a 64bit; reference the manifest file name (fancywm.json) so reviewers can easily follow the steps.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/fancywm.json`:
- Around line 1-38: The PR is missing the recommended local validation steps for
the fancywm manifest; add a brief "Testing" or "Local validation" section either
to the PR description or as a comment near the top of fancywm.json that lists
the exact commands to run: enable debug and set GH token (scoop config debug
true; scoop config gh_token <your-github-token>), run .\bin\checkver.ps1 -App
fancywm -f, run .\bin\formatjson.ps1 -App fancywm, and install locally with
scoop install .\bucket\fancywm.json -a 64bit; reference the manifest file name
(fancywm.json) so reviewers can easily follow the steps.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7b324182-068e-4452-917f-9f1bc0ec9d6e
📒 Files selected for processing (1)
bucket/fancywm.json
Closes ScoopInstaller#12212 Signed-off-by: Yan Cao <git@apvc.uk>
Signed-off-by: Yan Cao <git@apvc.uk>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/fancywm.json`:
- Around line 35-37: The autoupdate "hash" block currently points to
"$baseurl/checksums.txt" which 404s for FancyWM v2.19.0 and will break Scoop
autoupdate; fix by either removing the "hash" object (to skip hash validation)
or updating the "hash.url" to a real release asset containing checksums (replace
"$baseurl/checksums.txt" with the correct file URL from the v2.19.0 release),
ensuring the autoupdate.autoupdate/hash lookup uses the valid URL; verify the
change by running the autoupdate flow for version v2.19.0.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 08f0503e-7780-4d20-b833-779b63e6f05b
📒 Files selected for processing (1)
bucket/fancywm.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with fancywm
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/fancywm.json (1)
28-31: ⚡ Quick win
checkverties version detection to the Debug build asset — consider using the Release asset instead.The
regexpattern targetsFancyWM.Debug.x64.zipto extract the version, but the actual downloaded asset isFancyWM.Release.x64.zip. If a future release omits the Debug build (or renames it),checkverwill silently stop detecting new versions.Switching to the Release asset URL — or preferably reading
tag_namedirectly — makes version detection consistent with what actually gets installed.♻️ Proposed refactor
"checkver": { "github": "https://api.github.com/repos/FancyWM/fancywm/releases/latest", - "jsonpath": "$.assets..browser_download_url", - "regex": "/v([\\d.]+)/FancyWM\\.Debug\\.x64.zip" + "jsonpath": "$.tag_name", + "regex": "v([\\d.]+)" },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/fancywm.json` around lines 28 - 31, The checkver configuration currently extracts versions from the Debug asset via the "regex" under "checkver" (jsonpath: "$.assets..browser_download_url"), which doesn't match the actual installed Release asset; update the checkver to either (a) change the "regex" to target "FancyWM.Release.x64.zip" instead of "FancyWM.Debug.x64.zip" so it matches the downloaded asset, or (b) prefer extracting the version from the release "tag_name" field by changing "jsonpath" to read "$.tag_name" and adjusting/removing the "regex" accordingly; modify the "checkver" block (symbols: checkver, jsonpath, regex, tag_name) to implement one of these fixes so version detection aligns with the Release asset.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/fancywm.json`:
- Around line 28-31: The checkver configuration currently extracts versions from
the Debug asset via the "regex" under "checkver" (jsonpath:
"$.assets..browser_download_url"), which doesn't match the actual installed
Release asset; update the checkver to either (a) change the "regex" to target
"FancyWM.Release.x64.zip" instead of "FancyWM.Debug.x64.zip" so it matches the
downloaded asset, or (b) prefer extracting the version from the release
"tag_name" field by changing "jsonpath" to read "$.tag_name" and
adjusting/removing the "regex" accordingly; modify the "checkver" block
(symbols: checkver, jsonpath, regex, tag_name) to implement one of these fixes
so version detection aligns with the Release asset.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d9e9ca7d-bcdd-4b90-ba48-6b76d678e5b1
📒 Files selected for processing (1)
bucket/fancywm.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with fancywm
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. fancywm
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/fancywm.json`:
- Around line 26-30: The checkver regex currently extracts versions from
FancyWM.Debug.x64.zip but the manifest installs FancyWM.Release.x64.zip; update
the "checkver" -> "regex" to match the Release asset (e.g., target
FancyWM.Release.x64.zip) or a pattern that includes both Debug and Release so
version detection matches the asset downloaded by architecture.64bit.url and
remains robust if Debug builds are omitted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6f22ce7d-46f0-452b-ba1c-a0b818d0051a
📒 Files selected for processing (1)
bucket/fancywm.json
|
CodeRabbit chat interactions are restricted to organization members for this repository. Ask an organization member to interact with CodeRabbit, or set |
|
/verify |
|
All changes look good. Wait for review from human collaborators. fancywm
|
1 participant
Closes #12212
Note: FancyWM.exe can be launched as either a GUI program or a command line program with the following arguments:
fancywm.exe --action $ACTION
<manifest-name[@version]|chore>: <general summary of the pull request>