Skip to content

(chore): Move WebView2 from notes to suggest#17400

Merged
z-Fng merged 1 commit intomasterfrom
suggest-webview2
Mar 13, 2026
Merged

(chore): Move WebView2 from notes to suggest#17400
z-Fng merged 1 commit intomasterfrom
suggest-webview2

Conversation

@z-Fng
Copy link
Member

@z-Fng z-Fng commented Mar 12, 2026

ScoopInstaller/Scoop#6378 (comment)

VCRedist / .NET Runtime related

When they are suggested by manifest, it means that the app requires them. You can install them any way you want, not limited to Scoop

The same applies to Microsoft Edge WebView2.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

Release Notes

  • Refactor
    • Updated dependency suggestion mechanism across multiple packages. Required dependencies like Microsoft Edge WebView2 are now presented through an improved system for clearer installation guidance.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5136ade7-180b-4e34-829b-d761fd272b20

📥 Commits

Reviewing files that changed from the base of the PR and between 703ebb0 and 07cf711.

📒 Files selected for processing (5)
  • bucket/project-graph.json
  • bucket/rclone-manager.json
  • bucket/rclone-ui.json
  • bucket/seelen-ui.json
  • bucket/squirreldisk.json
🚧 Files skipped from review as they are similar to previous changes (5)
  • bucket/rclone-ui.json
  • bucket/squirreldisk.json
  • bucket/seelen-ui.json
  • bucket/rclone-manager.json
  • bucket/project-graph.json

Walkthrough

Five manifest files in the bucket directory are updated to replace inline "notes" fields describing Microsoft Edge WebView2 dependencies with a new "suggest" object structure that maps "Microsoft Edge WebView2" to "extras/webview2".

Changes

Cohort / File(s) Summary
Manifest Dependency Suggestion Updates
bucket/project-graph.json, bucket/rclone-manager.json, bucket/rclone-ui.json, bucket/seelen-ui.json, bucket/squirreldisk.json
Replaced "notes" field with "suggest" object mapping "Microsoft Edge WebView2" to "extras/webview2" across all manifests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

review-needed

Poem

Notes transformed to suggestions sweet,
Five manifests make the change complete,
WebView2 now hints the better way,
Dependencies dance in display! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly summarizes the main change: moving WebView2 references from notes to suggest fields across multiple manifest files.
Description check ✅ Passed The PR description follows the template structure, includes issue reference (#17085), provides context from related discussion, and confirms both checklist items completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch suggest-webview2
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@z-Fng z-Fng marked this pull request as draft March 12, 2026 20:27
@z-Fng z-Fng force-pushed the suggest-webview2 branch from 703ebb0 to 07cf711 Compare March 13, 2026 08:23
@z-Fng z-Fng marked this pull request as ready for review March 13, 2026 08:23
@z-Fng
Copy link
Member Author

z-Fng commented Mar 13, 2026

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

project-graph

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

rclone-manager

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

rclone-ui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

seelen-ui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

squirreldisk

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng merged commit b6a3701 into master Mar 13, 2026
5 checks passed
@z-Fng z-Fng deleted the suggest-webview2 branch March 13, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant