Skip to content

dngrep@4.7.10.0: Fix extract_dir, add arm64 support#17388

Merged
z-Fng merged 2 commits intoScoopInstaller:masterfrom
w4tchdoge:fix-dngrep-extractdir
Mar 11, 2026
Merged

dngrep@4.7.10.0: Fix extract_dir, add arm64 support#17388
z-Fng merged 2 commits intoScoopInstaller:masterfrom
w4tchdoge:fix-dngrep-extractdir

Conversation

@w4tchdoge
Copy link
Contributor

@w4tchdoge w4tchdoge commented Mar 11, 2026

  • Specified extract_dir on a per-architecture basis as x64 and x86 now have different extract dirs.
  • Remove manual hash check so that Scoop's Github Mode hash check can be used.
  • Add arm64 support.

Closes #17387

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features

    • Added ARM64 support with dedicated download, integrity info, and install layout.
    • Per-architecture extraction directories for 64-bit and 32-bit installs.
  • Chores

    • Simplified update metadata: autoupdate now includes per-architecture URLs; removed outdated top-level/regex lookup entries.

- Specified `extract_dir` on a per-architecture basis as x64 and x86 now
have different extract dirs.
- Remove manual hash check so that Github Mode can be used.
- Add arm64 support.
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Walkthrough

Per-architecture extract_dir entries were added (64bit, 32bit) and a new arm64 architecture was introduced with url/hash/extract_dir; the top-level extract_dir and autoupdate hash/regex block were removed and autoupdate was moved under architecture per-arch URLs.

Changes

Cohort / File(s) Summary
Manifest updates
bucket/dngrep.json
Moved extract_dir from top-level into architecture.64bit and architecture.32bit; added architecture.arm64 with url, hash, and extract_dir; removed top-level extract_dir; moved autoupdate to per-architecture URLs and removed autoupdate hash/regex lookup block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • z-Fng

Poem

🐰 I hopped through manifests, sniffed each file and dir,
Moved paths to each arch, so MSIs no longer err,
64, 32, and arm64—now all find their way,
A carrot for CI, and a hop for the day! 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description includes linked issue #17387, explains the key changes (per-architecture extract_dir, removing manual hash check, adding arm64), and confirms compliance with contributing guidelines.
Linked Issues check ✅ Passed The PR directly addresses issue #17387 by updating extract_dir to use per-architecture paths (PFiles64 for x64, PFiles for x86) and adds arm64 support. The hash check removal aligns with enabling Scoop's native hash validation.
Out of Scope Changes check ✅ Passed All changes in bucket/dngrep.json are directly related to the linked issue objectives: fixing extract_dir paths, removing manual hash checks, and adding arm64 architecture support. No out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title directly and clearly describes the two main changes: fixing extract_dir and adding arm64 support, which align with the primary objectives of the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

dngrep

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@w4tchdoge
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

dngrep

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/dngrep.json`:
- Around line 9-20: The manifest has a JSON spacing regression: the three
occurrences of the extract_dir property are written as extract_dir":"... without
a space after the colon; update each occurrence of the "extract_dir" entries in
dngrep.json (the 64-bit, 32-bit and arm64 objects) to use the same spaced
separator as the rest of the file (i.e. change "extract_dir":"PFiles64\\dnGrep"
to "extract_dir": "PFiles64\\dnGrep", and similarly for "PFiles\\dnGrep" and the
arm64 entry) so the file passes the linter.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7f2cbbd0-a11c-4cb1-a349-e95cdf70442d

📥 Commits

Reviewing files that changed from the base of the PR and between c7d1a72 and 20ea1cf.

📒 Files selected for processing (1)
  • bucket/dngrep.json

@z-Fng z-Fng changed the title dngrep: Fix extract_dir & hash check, add arm64 dngrep@4.7.10.0: Fix extract_dir, add arm64 support Mar 11, 2026
Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 6de9da8 into ScoopInstaller:master Mar 11, 2026
3 checks passed
@w4tchdoge w4tchdoge deleted the fix-dngrep-extractdir branch March 11, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: dngrep fails to find extract_dir

2 participants