dngrep@4.7.10.0: Fix extract_dir, add arm64 support#17388
dngrep@4.7.10.0: Fix extract_dir, add arm64 support#17388z-Fng merged 2 commits intoScoopInstaller:masterfrom
Conversation
- Specified `extract_dir` on a per-architecture basis as x64 and x86 now have different extract dirs. - Remove manual hash check so that Github Mode can be used. - Add arm64 support.
WalkthroughPer-architecture extract_dir entries were added (64bit, 32bit) and a new arm64 architecture was introduced with url/hash/extract_dir; the top-level extract_dir and autoupdate hash/regex block were removed and autoupdate was moved under architecture per-arch URLs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with dngrep
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. dngrep
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/dngrep.json`:
- Around line 9-20: The manifest has a JSON spacing regression: the three
occurrences of the extract_dir property are written as extract_dir":"... without
a space after the colon; update each occurrence of the "extract_dir" entries in
dngrep.json (the 64-bit, 32-bit and arm64 objects) to use the same spaced
separator as the rest of the file (i.e. change "extract_dir":"PFiles64\\dnGrep"
to "extract_dir": "PFiles64\\dnGrep", and similarly for "PFiles\\dnGrep" and the
arm64 entry) so the file passes the linter.
extract_diron a per-architecture basis as x64 and x86 now have different extract dirs.Closes #17387
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
New Features
Chores