(chore): Revert to using repo name in checkver#17382
(chore): Revert to using repo name in checkver#17382z-Fng merged 1 commit intoScoopInstaller:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (106)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (51)
WalkthroughBulk update replacing deprecated GitHub repository-ID API URLs with owner/repo API paths in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
bucket/deeplx.json (1)
18-18: Consider using the repository ID endpoint for better resilience.The current
owner/repoformat is vulnerable to organization renames. GitHub's REST API does not redirect requests that use a renamed organization name—they return404 Not Found. Using the numeric repository endpoint (/repositories/{id}) would be immune to this change, makingcheckvermore reliable.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/deeplx.json` at line 18, Replace the current GitHub releases URL string value assigned to the "url" key (the owner/repo form "https://api.github.com/repos/OwO-Network/DeepLX/releases") with the numeric repository endpoint to avoid breakage on org renames: use "https://api.github.com/repositories/{repo_id}/releases" (substitute the actual repository numeric ID) so checkver queries the /repositories/{id}/releases endpoint instead of /repos/{owner}/{repo}/releases.bucket/ubports-installer.json (1)
4-4: Pre-existing issue: Malformed homepage URL.The homepage URL
https://ubuntu-touch.io//ubuntu-touch.iocontains a double slash and repeated domain. This appears to be a pre-existing issue unrelated to this PR, but worth fixing.- "homepage": "https://ubuntu-touch.io//ubuntu-touch.io", + "homepage": "https://ubuntu-touch.io",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/ubports-installer.json` at line 4, The "homepage" JSON entry currently contains a malformed URL ("https://ubuntu-touch.io//ubuntu-touch.io"); update the "homepage" key's value to the correct canonical URL ("https://ubuntu-touch.io") by replacing the duplicated domain and removing the extra slash so the JSON entry reads a single valid homepage URL.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/scoop-sd.json`:
- Line 10: The checkver "url" is pointing to the wrong GitHub owner (ergolyam)
which mismatches the package's homepage/download/autoupdate owner (grisha765);
update the checkver "url" value to reference "grisha765/scoop-search-directory"
so all GitHub endpoints use the same repository owner and avoid querying the
wrong repo for releases.
---
Nitpick comments:
In `@bucket/deeplx.json`:
- Line 18: Replace the current GitHub releases URL string value assigned to the
"url" key (the owner/repo form
"https://api.github.com/repos/OwO-Network/DeepLX/releases") with the numeric
repository endpoint to avoid breakage on org renames: use
"https://api.github.com/repositories/{repo_id}/releases" (substitute the actual
repository numeric ID) so checkver queries the /repositories/{id}/releases
endpoint instead of /repos/{owner}/{repo}/releases.
In `@bucket/ubports-installer.json`:
- Line 4: The "homepage" JSON entry currently contains a malformed URL
("https://ubuntu-touch.io//ubuntu-touch.io"); update the "homepage" key's value
to the correct canonical URL ("https://ubuntu-touch.io") by replacing the
duplicated domain and removing the extra slash so the JSON entry reads a single
valid homepage URL.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5649a371-533a-466b-a9ca-913e08948aba
📒 Files selected for processing (106)
bucket/86box.jsonbucket/adventuregamestudio.jsonbucket/age.jsonbucket/bambu-studio.jsonbucket/bitwarden.jsonbucket/bloop.jsonbucket/boilr.jsonbucket/browseros.jsonbucket/bulk-crap-uninstaller.jsonbucket/cake-wallet.jsonbucket/capframex.jsonbucket/cefflashbrowser.jsonbucket/chromium.jsonbucket/clingo.jsonbucket/converseen.jsonbucket/deeplx.jsonbucket/dismplusplus.jsonbucket/dn-famitracker.jsonbucket/dosbox-x.jsonbucket/duckdns.jsonbucket/fancontrol.jsonbucket/folo.jsonbucket/fontforge.jsonbucket/free-shooter.jsonbucket/freecad.jsonbucket/fvim.jsonbucket/garbro.jsonbucket/ghidra.jsonbucket/gitextensions.jsonbucket/github.jsonbucket/gnucash.jsonbucket/goldendict.jsonbucket/gossip.jsonbucket/hemmelig.jsonbucket/hoppscotch.jsonbucket/hydrus-network.jsonbucket/inkscape-extension-sozi.jsonbucket/insomnia.jsonbucket/ios-webkit-debug-proxy.jsonbucket/ipfilter-updater.jsonbucket/jasper.jsonbucket/jexiftoolgui.jsonbucket/kdoc-formatter.jsonbucket/lightbulb.jsonbucket/magicavoxel.jsonbucket/mediaelch.jsonbucket/meshroom.jsonbucket/moosync.jsonbucket/mpc-hc-fork.jsonbucket/mpv-git.jsonbucket/neovim-qt.jsonbucket/notesnook.jsonbucket/odict.jsonbucket/onlyoffice-desktopeditors.jsonbucket/persepolis.jsonbucket/prusaslicer.jsonbucket/puttie.jsonbucket/qefi-entry-manager.jsonbucket/redasm.jsonbucket/retroshare.jsonbucket/ripme.jsonbucket/rssguard.jsonbucket/saber.jsonbucket/scoop-completion.jsonbucket/scoop-sd.jsonbucket/sdl2-image.jsonbucket/sdl2-mixer.jsonbucket/sdl2-ttf.jsonbucket/sdl2.jsonbucket/shaderglass.jsonbucket/simplewall.jsonbucket/so.jsonbucket/soundswitch.jsonbucket/sozi.jsonbucket/spicetify-themes.jsonbucket/spotify-qt.jsonbucket/stack-wallet.jsonbucket/standardnotes.jsonbucket/status.jsonbucket/streamlabs-obs.jsonbucket/streamlink.jsonbucket/subsync.jsonbucket/supermium.jsonbucket/suwayomi-server.jsonbucket/switchhosts.jsonbucket/tcno-acc-switcher.jsonbucket/tern-subtitle-file-translator.jsonbucket/thonny.jsonbucket/thorium.jsonbucket/tlaplus-toolbox.jsonbucket/todolist.jsonbucket/total-registry.jsonbucket/ubports-installer.jsonbucket/uefitool.jsonbucket/uniextract2.jsonbucket/universal-android-debloater.jsonbucket/vcxsrv.jsonbucket/virgo.jsonbucket/wasabi-wallet.jsonbucket/windterm.jsonbucket/yesplaymusic.jsonbucket/yoke.jsonbucket/youtube-dl-gui.jsonbucket/zeronet.jsondeprecated/fmedia.jsondeprecated/nekoray.json
60c5d8e to
9aca2eb
Compare
|
/verify |
|
All changes look good. Wait for review from human collaborators. 86box
adventuregamestudio
age
bambu-studio
bitwarden
bloop
boilr
browseros
bulk-crap-uninstaller
cake-wallet
capframex
cefflashbrowser
chromium
clingo
converseen
deeplx
dismplusplus
dn-famitracker
dosbox-x
duckdns
fancontrol
folo
fontforge
free-shooter
freecad
fvim
garbro
ghidra
gitextensions
github
gnucash
goldendict
gossip
hemmelig
hoppscotch
hydrus-network
inkscape-extension-sozi
insomnia
ios-webkit-debug-proxy
ipfilter-updater
jasper
jexiftoolgui
kdoc-formatter
lightbulb
magicavoxel
mediaelch
meshroom
moosync
mpc-hc-fork
mpv-git
neovim-qt
notesnook
odict
onlyoffice-desktopeditors
persepolis
prusaslicer
puttie
qefi-entry-manager
redasm
retroshare
ripme
rssguard
saber
scoop-completion
scoop-sd
sdl2-image
sdl2-mixer
sdl2-ttf
sdl2
shaderglass
simplewall
so
soundswitch
sozi
spicetify-themes
spotify-qt
stack-wallet
standardnotes
status
streamlabs-obs
streamlink
subsync
supermium
suwayomi-server
switchhosts
tcno-acc-switcher
tern-subtitle-file-translator
thonny
thorium
tlaplus-toolbox
todolist
total-registry
ubports-installer
uefitool
uniextract2
universal-android-debloater
vcxsrv
virgo
wasabi-wallet
windterm
yesplaymusic
yoke
youtube-dl-gui
zeronet
|
Reverted checkver to use the repo name to improve readability since GitHub API handles redirects natively.
Relates to:
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit