Skip to content

effekseer: Update to version 1.7.3.0, fix checkver, drop 32-bit version#17376

Merged
z-Fng merged 1 commit intoScoopInstaller:masterfrom
SorYoshino:effekseer
Mar 9, 2026
Merged

effekseer: Update to version 1.7.3.0, fix checkver, drop 32-bit version#17376
z-Fng merged 1 commit intoScoopInstaller:masterfrom
SorYoshino:effekseer

Conversation

@SorYoshino
Copy link
Contributor

@SorYoshino SorYoshino commented Mar 9, 2026

Summary

Updates effekseer to version 1.7.3.0, refines the versioning scheme, and modernizes the update logic.

Related issues or pull requests

Changes

  • Update Homepage: Point to the English index page for better accessibility.
  • Update version to 1.7.3.0: Migrate from the old alphanumeric versioning (e.g., 170e) to the standard semantic versioning used in recent releases.
  • Drop 32-bit Support: Remove the 32bit architecture from architecture and autoupdate as the upstream no longer provides 32-bit binaries for the latest versions.
  • Modernize checkver:
    • Switch from the basic GitHub helper to the GitHub API.
    • Implement jsonpath to filter for stable releases and specifically target the Win.zip asset.
    • Improve regex to ensure accurate version extraction from the download URL.

Notes

  • Not all released versions provide corresponding packages, such as version 1.7.2.0. Therefore, jsonpath filtering is required.

Testing

The test results are as follows:
┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ develop ≡]
└─> .\checkver.ps1 -App effekseer -Dir 'D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket' -f
effekseer: 1.7.3.0 (scoop version is 1.7.3.0)
Forcing autoupdate!
Autoupdating effekseer
DEBUG[1773034042] [$updatedProperties] = [url hash] -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:500:5
DEBUG[1773034042] $substitutions (hashtable) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:230:5
DEBUG[1773034042] $substitutions.$url                           https://github.com/effekseer/Effekseer/releases/download/1.7.3.0/Effekseer1.7.3.0Win.zip
DEBUG[1773034042] $substitutions.$cleanVersion                  1730
DEBUG[1773034042] $substitutions.$basenameNoExt                 Effekseer1.7.3.0Win
DEBUG[1773034042] $substitutions.$majorVersion                  1
DEBUG[1773034042] $substitutions.$underscoreVersion             1_7_3_0
DEBUG[1773034042] $substitutions.$buildVersion                  0
DEBUG[1773034042] $substitutions.$preReleaseVersion             1.7.3.0
DEBUG[1773034042] $substitutions.$match1                        1.7.3.0
DEBUG[1773034042] $substitutions.$version                       1.7.3.0
DEBUG[1773034042] $substitutions.$urlNoExt                      https://github.com/effekseer/Effekseer/releases/download/1.7.3.0/Effekseer1.7.3.0Win
DEBUG[1773034042] $substitutions.$minorVersion                  7
DEBUG[1773034042] $substitutions.$dashVersion                   1-7-3-0
DEBUG[1773034042] $substitutions.$basename                      Effekseer1.7.3.0Win.zip
DEBUG[1773034042] $substitutions.$matchHead                     1.7.3
DEBUG[1773034042] $substitutions.$patchVersion                  3
DEBUG[1773034042] $substitutions.$matchTail                     .0
DEBUG[1773034042] $substitutions.$baseurl                       https://github.com/effekseer/Effekseer/releases/download/1.7.3.0
DEBUG[1773034042] $substitutions.$dotVersion                    1.7.3.0
DEBUG[1773034042] $hashfile_url = $null -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:233:5
DEBUG[1773034044] $jsonpath = $..assets[?(@.browser_download_url == 'https://github.com/effekseer/Effekseer/releases/download/1.7.3.0/Effekseer1.7.3.0Win.zip')].digest -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:140:5
Found: 155212c5ec4d365eb1a4a5cbe25a03cfc59893723ec6680e462de4f49e605b69 using Github Mode
Writing updated effekseer manifest
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated package to version 1.7.3.0
    • Removed 32-bit architecture support; 64-bit only
    • Updated homepage reference

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 444f3be8-66e3-4d40-8abe-da767e96abf3

📥 Commits

Reviewing files that changed from the base of the PR and between 6a0c7bc and 50f87fd.

📒 Files selected for processing (1)
  • bucket/effekseer.json

Walkthrough

This PR updates the Effekseer package manifest to version 1.7.3.0, removing 32-bit architecture support, updating download URLs and hashes for 64-bit builds, adjusting persist file order, and converting version checking to use GitHub API with JSONPath filtering.

Changes

Cohort / File(s) Summary
Manifest Update
bucket/effekseer.json
Updated version from 170e to 1.7.3.0; removed 32-bit architecture block; updated 64-bit download URL and hash; reordered persist entries; converted checkver to GitHub API with JSONPath for non-prerelease Windows assets; updated autoupdate template accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 An old version fades like morning dew,
One-point-seven-three, fresh and new!
Thirty-two bits? We bid adieu,
API checks make manifests true! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: updating effekseer to version 1.7.3.0, fixing checkver logic, and dropping 32-bit support.
Description check ✅ Passed The PR description comprehensively covers the changes, includes a reference to the linked issue (#17373), and demonstrates testing with actual output.
Linked Issues check ✅ Passed All coding requirements from issue #17373 are met: manifest updated to version 1.7.3.0, 32-bit support removed, checkver modernized, and homepage updated.
Out of Scope Changes check ✅ Passed All changes directly address the objectives in issue #17373; no extraneous modifications to unrelated files or functionality were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

All changes look good.

Wait for review from human collaborators.

effekseer

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit c7f2bc1 into ScoopInstaller:master Mar 9, 2026
4 checks passed
@SorYoshino SorYoshino deleted the effekseer branch March 9, 2026 06:48
@anderlli0053
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Effekseer should be updated to the latest version

3 participants