cinny: Update license, suggest `webview2` by kfiven · Pull Request #17368 · ScoopInstaller/Extras

kfiven · 2026-03-07T07:27:25Z

Updated license to AGPL-3.0-only and added notes about MSEdgeWebview2 dependency.

Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
I have read the Contributing Guide

Summary by CodeRabbit

Chores
- Project license updated to AGPL-3.0-only.
- Declared a new dependency on WebView2 required for the app.
Documentation
- Expanded user-facing notes: settings location, WebView2 requirement, official download link, and an alternative install command.

Updated license to AGPL-3.0-only and added notes about MSEdgeWebview2 dependency.

coderabbitai · 2026-03-07T07:27:39Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Updated bucket/cinny.json: license changed from MIT to AGPL-3.0-only, notes converted from a single string to an array with entries about MSEdgeWebview2 (incl. download link and scoop install suggestion), and a new depends field "webview2" added.

Changes

Cohort / File(s)	Summary
Manifest Configuration `bucket/cinny.json`	`license` updated `MIT` → `AGPL-3.0-only`; `notes` changed from a string to an array listing settings location, MSEdgeWebview2 dependency, download link, and `scoop install extras/webview2`; added `"depends": "webview2"`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

review-needed

Suggested reviewers

z-Fng

Poem

🐰 A manifest hopped from old to new,
License swapped and notes grew a crew,
"Fetch WebView2!" I nudge with care,
A scoop, a link, a tiny flair,
Hoppity-hop — configuration renewed. 🌿

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'cinny: Update license, suggest `webview2`' accurately summarizes the main changes: license update to AGPL-3.0-only and addition of webview2 dependency information.
Description check	✅ Passed	The PR description provides a clear summary of changes and confirms compliance with repository guidelines through completed checklists.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-07T07:28:35Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

Invalid manifests

cinny

Check the full log for details.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/cinny.json`:
- Around line 6-12: The JSON in the "notes" array is invalid because one element
is missing a trailing comma; update the "notes" array (the value for the "notes"
key) so each string element is comma-separated—specifically add a comma after
the first string element that ends with "in.cinny.app directory." so the array
elements are valid JSON.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a944d855-8b4d-4953-8ccd-049f8420d5e2

📥 Commits

Reviewing files that changed from the base of the PR and between feddfe5 and 46014d4.

📒 Files selected for processing (1)

bucket/cinny.json

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/cinny.json`:
- Around line 38-39: Remove the two trailing blank lines at the end of
cinny.json so the file ends immediately after the closing brace followed by a
single newline; locate the final closing "}" in cinny.json and ensure there is
exactly one newline character after it (no extra empty lines) to satisfy JSON
formatting/linter expectations.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2822631-5c4d-4ac2-a8eb-2da5e4988630

📥 Commits

Reviewing files that changed from the base of the PR and between 46014d4 and 01e7a3f.

📒 Files selected for processing (1)

bucket/cinny.json

bucket/cinny.json

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/cinny.json`:
- Around line 6-12: The manifest only documents WebView2 in the "notes" array so
Scoop won't auto-install it; add a top-level "depends": "webview2" key to the
JSON manifest (next to existing keys like "notes") so the WebView2 runtime is
declared as a dependency and will be installed automatically with the app.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4cc7d8bc-3922-42f5-8ac7-5d76673225dc

📥 Commits

Reviewing files that changed from the base of the PR and between 01e7a3f and 32c9674.

📒 Files selected for processing (1)

bucket/cinny.json

bucket/cinny.json

Added 'depends' field for webview2 dependency.

coderabbitai

♻️ Duplicate comments (1)

bucket/cinny.json (1)
39-39: ⚠️ Potential issue | 🟡 Minor

Remove the remaining trailing blank line.

Line 39 still leaves an extra empty line after the closing brace. The file should end immediately after } with a single newline.
🧹 Proposed fix
 }
-
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/cinny.json` at line 39, Remove the extra blank line at the end of
bucket/cinny.json so the file ends immediately after the closing brace `}`
followed by a single newline; open the file, delete any trailing empty lines
after `}`, and ensure exactly one newline character remains at EOF.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@bucket/cinny.json`:
- Line 39: Remove the extra blank line at the end of bucket/cinny.json so the
file ends immediately after the closing brace `}` followed by a single newline;
open the file, delete any trailing empty lines after `}`, and ensure exactly one
newline character remains at EOF.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc197958-6023-4ebd-89ea-a33e3502991a

📥 Commits

Reviewing files that changed from the base of the PR and between 32c9674 and 708b89c.

📒 Files selected for processing (1)

bucket/cinny.json

z-Fng · 2026-03-07T19:23:46Z

bucket/cinny.json

+        "https://developer.microsoft.com/en-us/microsoft-edge/webview2/#download-section",
+        "or run `scoop install extras/webview2`"
+    ],
+    "depends": "webview2",


Given that Microsoft Edge WebView2 is already preinstalled on Windows 11 and most Windows 10 systems, I believe it suffices to list it as a suggestion like the .NET Desktop Runtime -- it doesn't even need to be mentioned in the notes.

Extras/bucket/everythingtoolbar.json

Line 11 in 6a78a9d

".NET Desktop Runtime 8.0": "versions/windowsdesktop-runtime-8.0"

z-Fng · 2026-03-07T19:29:33Z

/verify

github-actions · 2026-03-07T19:30:34Z

All changes look good.

Wait for review from human collaborators.

cinny

Check the full log for details.

z-Fng

Thanks for your contribution!

Modify cinny.json with new license and notes

46014d4

Updated license to AGPL-3.0-only and added notes about MSEdgeWebview2 dependency.

github-actions bot added the manifest-fix-needed label Mar 7, 2026

coderabbitai bot reviewed Mar 7, 2026

View reviewed changes

kfiven changed the title ~~Modify cinny.json with new license and notes~~ cinny@4.10.5|chore: Update license matching the repo and add notes about webview2 dep Mar 7, 2026

Format cinny.json with consistent syntax

01e7a3f

coderabbitai bot reviewed Mar 7, 2026

View reviewed changes

bucket/cinny.json Outdated Show resolved Hide resolved

Remove extra space

32c9674

coderabbitai bot reviewed Mar 7, 2026

View reviewed changes

bucket/cinny.json Outdated Show resolved Hide resolved

Add dependency for webview2 in cinny.json

708b89c

Added 'depends' field for webview2 dependency.

coderabbitai bot reviewed Mar 7, 2026

View reviewed changes

-

7838f4c

z-Fng changed the title ~~cinny@4.10.5|chore: Update license matching the repo and add notes about webview2 dep~~ cinny: Update license & notes Mar 7, 2026

z-Fng reviewed Mar 7, 2026

View reviewed changes

Suggest Microsoft Edge WebView2

6a02c1c

z-Fng changed the title ~~cinny: Update license & notes~~ cinny: Update license, suggest webview2 Mar 7, 2026

github-actions bot added review-needed and removed manifest-fix-needed labels Mar 7, 2026

z-Fng approved these changes Mar 7, 2026

View reviewed changes

z-Fng merged commit e3cdeaf into ScoopInstaller:master Mar 7, 2026
3 checks passed

kfiven deleted the patch-1 branch March 7, 2026 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cinny: Update license, suggest `webview2`#17368

cinny: Update license, suggest `webview2`#17368
z-Fng merged 6 commits intoScoopInstaller:masterfrom
kfiven:patch-1

kfiven commented Mar 7, 2026 •

edited by z-Fng

Loading

Uh oh!

coderabbitai bot commented Mar 7, 2026 •

edited

Loading

Reviews paused

Uh oh!

github-actions bot commented Mar 7, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

z-Fng Mar 7, 2026 •

edited

Loading

Uh oh!

z-Fng commented Mar 7, 2026

Uh oh!

github-actions bot commented Mar 7, 2026

Uh oh!

z-Fng left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kfiven commented Mar 7, 2026 • edited by z-Fng Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Uh oh!

github-actions bot commented Mar 7, 2026

Invalid manifests

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

z-Fng Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

z-Fng commented Mar 7, 2026

Uh oh!

github-actions bot commented Mar 7, 2026

cinny

Uh oh!

z-Fng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kfiven commented Mar 7, 2026 •

edited by z-Fng

Loading

coderabbitai bot commented Mar 7, 2026 •

edited

Loading

z-Fng Mar 7, 2026 •

edited

Loading