hiddify: Simplify checkver & autoupdate, refactor persistence logic#17362
hiddify: Simplify checkver & autoupdate, refactor persistence logic#17362z-Fng merged 2 commits intoScoopInstaller:masterfrom
Conversation
WalkthroughThis PR updates the Hiddify Scoop manifest: expands the description, normalizes the homepage URL, tightens the license identifier, removes installer/uninstaller scripts, switches checkver to a GitHub reference, sets an explicit autoupdate URL, and adds a persist entry. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. hiddify
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. hiddify
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/hiddify.json`:
- Line 23: Add a migration step to pre_install or post_install that detects
existing data in the old junction path "$env:APPDATA\\Hiddify" and moves or
copies it into the new persist directory identified by the manifest key
"persist": "hiddify_portable_data"; implement checks to skip if destination
already contains newer data and ensure file permissions/ownership are preserved,
and log actions and failures via the installer script so upgrades retain user
profiles and settings instead of losing them.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b456bf5f-9f4d-4d7d-bcce-3ec8b0bcf290
📒 Files selected for processing (1)
bucket/hiddify.json
Summary
Refines the
hiddifymanifest by simplifying the update logic, improving metadata accuracy, and removing redundant installation scripts.Related issues or pull requests
Changes
descriptionto better reflect the app's capabilities and underlying toolchain (Sing-box).licenseidentifier to the more specificGPL-3.0-only.installeranduninstallerscripts that managed a junction in%APPDATA%.checkverto use the standardgithubhelper instead of a manual API call with complex JSONPath.autoupdateURL by using a static filename pattern instead of relying on regex capture groups.Notes
$dir.checkverlogic could cause the manifest to be automatically updated to pre-release versions. For GitHub sources, the default version checking method is already sufficient.Testing
The test results are as follows:
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit