Skip to content

locale_remulator@1.6.0: Add version 1.6.0#17361

Open
deuteros-gex wants to merge 2 commits intoScoopInstaller:masterfrom
deuteros-gex:add-lr
Open

locale_remulator@1.6.0: Add version 1.6.0#17361
deuteros-gex wants to merge 2 commits intoScoopInstaller:masterfrom
deuteros-gex:add-lr

Conversation

@deuteros-gex
Copy link
Contributor

@deuteros-gex deuteros-gex commented Mar 6, 2026

closes ScoopInstaller/Main#7698

I believe it's better to persist the config file LRConfig.xml between installations, but simply creating an empty LRConfig.xml doesn't work, 'cause the program refuses to run at all using a empty config file.

So there might be 2 ways:

  • Manually create a full default config file, of which the content is below
  • Run LRProc.exe once after it is extracted, and we got a default config file, then kill the process.

I took the latter one, since it is way easier to write the script.
What confuses me is that LRProc.exe is actually a GUI program which accepts CLI arguments, although the installer script are tested to worked on my local computer, I have no ides whether it can pass those CI/CD workflows or rebot reviews

<?xml version="1.0" encoding="utf-8"?>
<LRConfig>
  <Profiles Type="exe">
    <Profile Name="Run in Japanese" Guid="fb0c87bb-fa60-49f3-ba0d-3132699e285a">
      <Location>ja-JP</Location>
      <CodePage>932</CodePage>
      <LCID>1041</LCID>
      <TimeZone>Tokyo Standard Time</TimeZone>
      <Bias>540</Bias>
      <RunAsAdmin>false</RunAsAdmin>
      <HookIME>false</HookIME>
      <HookLCID>true</HookLCID>
    </Profile>
    <Profile Name="Run in Japanese (Admin)" Guid="db7b6986-f6e8-473d-9f0b-ff53a6cbc035">
      <Location>ja-JP</Location>
      <CodePage>932</CodePage>
      <LCID>1041</LCID>
      <TimeZone>Tokyo Standard Time</TimeZone>
      <Bias>540</Bias>
      <RunAsAdmin>true</RunAsAdmin>
      <HookIME>true</HookIME>
      <HookLCID>true</HookLCID>
    </Profile>
    <Profile Name="Run in Taiwan (Admin)" Guid="937df259-7cb9-4da2-be5a-3ec430b81393">
      <Location>zh-TW</Location>
      <CodePage>950</CodePage>
      <LCID>1028</LCID>
      <TimeZone>Taipei Standard Time</TimeZone>
      <Bias>480</Bias>
      <RunAsAdmin>true</RunAsAdmin>
      <HookIME>true</HookIME>
      <HookLCID>true</HookLCID>
    </Profile>
    <Profile Name="Run in Korean (Admin)" Guid="9596cb07-5bd2-45f8-b6dd-ec0752446b4b">
      <Location>ko-KR</Location>
      <CodePage>949</CodePage>
      <LCID>1042</LCID>
      <TimeZone>Korea Standard Time</TimeZone>
      <Bias>540</Bias>
      <RunAsAdmin>true</RunAsAdmin>
      <HookIME>true</HookIME>
      <HookLCID>true</HookLCID>
    </Profile>
  </Profiles>
</LRConfig>

Last but no least, LRProc.exe does accept CLI arguments.

LRProc.exe /?

---------------------------
Locale Remulator x64
---------------------------

Welcome to Locale Remulator x64 command line tool.

Usage: LRProc.exe GUID Path Args

GUID	Guid of the target profile (in LRConfig.xml).
Path	Full path of the target application.
Args	Additional arguments will be passed to the application.

You can also run LREditor to use this applicaction.
				
---------------------------
OK   
---------------------------
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Added Locale Remulator v1.6.0 package with automatic installer initialization on first install.
    • Included convenient shortcuts for Locale Remulator Installer and Editor applications.
    • Enabled automatic updates via GitHub releases integration.

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Walkthrough

A new Scoop package manifest is added for Locale Remulator v1.6.0, a system region and language simulator. The manifest includes installation logic to initialize configuration files on first run and defines automated update mechanisms via GitHub releases.

Changes

Cohort / File(s) Summary
New Package Manifest
bucket/locale_remulator.json
Adds Scoop manifest for Locale Remulator v1.6.0 with installer script that generates LRConfig.xml via LRProc.exe on first install, persistent configuration and binary files, shortcuts for installer and editor executables, and GitHub-based version control and autoupdate configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 A locale-shifting tool hops into place,
With config files and shortcuts with grace,
Remulator now joins the Scoop array,
System regions bend the rabbit's way! 🌍✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a new manifest file for Locale Remulator version 1.6.0, following conventional Scoop PR naming conventions.
Linked Issues check ✅ Passed The manifest implementation fulfills all objectives from issue #7698: adds Locale_Remulator v1.6.0, uses the correct download URL, meets all criteria (non-GUI, popular, stable full version), and includes necessary config initialization.
Out of Scope Changes check ✅ Passed The PR contains only the new manifest file for Locale Remulator with installer logic for config generation, which is directly within scope of the linked issue requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description provides comprehensive context about the technical challenge, solution rationale, and includes PR checklist items completed. However, it does not follow the template structure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

All changes look good.

Wait for review from human collaborators.

locale_remulator

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/locale_remulator.json`:
- Around line 15-20: Fix the PowerShell string literals and make LRConfig
generation robust: remove leading/trailing spaces in the strings around the
Test-Path/Start-Process/Stop-Process block, correct the message grammar in the
Write-Host call, avoid brittle hardcoded termination by waiting/checking for
LRConfig.xml rather than blindly killing LRProc.exe, add error handling around
Stop-Process (use -ErrorAction SilentlyContinue) and verify with Test-Path that
\"$persist_dir\\LRConfig.xml\" exists after $proc_tmp completes (log a warning
via Write-Host if it does not). Use the existing symbols to locate edits:
Test-Path, Start-Process (that returns $proc_tmp), Stop-Process, Write-Host, and
LRConfig.xml/LRProc.exe.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eb60fcce-a497-4734-9179-181dc172878b

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc092d and 94b5789.

📒 Files selected for processing (1)
  • bucket/locale_remulator.json

@deuteros-gex
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

All changes look good.

Wait for review from human collaborators.

locale_remulator

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Locale_Remulator

1 participant