open-tv: Rename to fred-tv#17360
Conversation
|
All changes look good. Wait for review from human collaborators. fred-tv
|
fred-tv
WalkthroughAdded deprecation metadata and messaging to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
i clicked on "update branch", is it ok now? i am a newbie on this... or can you do it instead of me? |
What I mean is that I recommend you recreate a new manifest named |
|
/verify |
|
All changes look good. Wait for review from human collaborators. fred-tv
open-tv
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/open-tv.json (1)
7-18: Add the manual migration command to the deprecation note.This tells users what to install next, but not how to move off the deprecated manifest. Since
open-tvis intentionally staying around for a grace period, make the note explicit with the uninstall/install step so users don't remain on the old manifest until removal.Suggested tweak
"notes": [ "`open-tv` has been renamed to `fred-tv`.", - "This manifest is deprecated and scheduled for removal on 2026-09-01. Please use `extras/fred-tv` instead." + "This manifest is deprecated and scheduled for removal on 2026-09-01.", + "To migrate, run: `scoop uninstall open-tv` and then `scoop install extras/fred-tv`." ],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/open-tv.json` around lines 7 - 18, Update the "notes" entry for the deprecated manifest to include an explicit manual migration command so users know how to move from "open-tv" to "extras/fred-tv"; specifically, append a line to the notes array that shows the uninstall/install step (referencing "open-tv" and "extras/fred-tv") with the package commands your project uses (e.g., replace with the project's package manager syntax: uninstall open-tv then install extras/fred-tv), and keep the existing deprecation message and removal date intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/open-tv.json`:
- Around line 27-30: The manifest's shortcuts array currently uses the display
name "Fred TV" which duplicates bucket/fred-tv.json and hides that this package
is deprecated; update the shortcuts entry for "open_tv.exe" in open-tv.json to a
visually distinct label such as "Open TV (deprecated)" or "Open TV — legacy" so
users can easily tell this is the old package during the transition window.
---
Nitpick comments:
In `@bucket/open-tv.json`:
- Around line 7-18: Update the "notes" entry for the deprecated manifest to
include an explicit manual migration command so users know how to move from
"open-tv" to "extras/fred-tv"; specifically, append a line to the notes array
that shows the uninstall/install step (referencing "open-tv" and
"extras/fred-tv") with the package commands your project uses (e.g., replace
with the project's package manager syntax: uninstall open-tv then install
extras/fred-tv), and keep the existing deprecation message and removal date
intact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c110d9b8-5486-42ce-9ac9-5f760cb7f4ba
📒 Files selected for processing (1)
bucket/open-tv.json
z-Fng
left a comment
There was a problem hiding this comment.
- Use conventional PR title:
<manifest-name[@version]|chore>: <general summary of the pull request>- I have read the Contributing Guide
Please make sure to follow the Contributing Guide and use conventional PR title next time.
Thanks for your contribution!
the project was renamed
Summary by CodeRabbit