Skip to content

open-tv: Rename to fred-tv#17360

Merged
z-Fng merged 4 commits intoScoopInstaller:masterfrom
bt4ibwem8:patch-1
Mar 8, 2026
Merged

open-tv: Rename to fred-tv#17360
z-Fng merged 4 commits intoScoopInstaller:masterfrom
bt4ibwem8:patch-1

Conversation

@bt4ibwem8
Copy link
Contributor

@bt4ibwem8 bt4ibwem8 commented Mar 6, 2026

the project was renamed

Summary by CodeRabbit

  • Chores
    • Renamed launcher/shortcut label from "Open TV" to "Fred TV".
  • Documentation
    • Added a deprecation notice for the legacy manifest, including removal date (after 2026-09-01) and a suggested replacement mapping.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

All changes look good.

Wait for review from human collaborators.

fred-tv

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title the project was renamed from 'Open TV' to 'Fred TV' open-tv: Rename to fred-tv Mar 6, 2026
Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Scoop does not yet support automatic manifest replacement, we should keep the original manifest for a few months and include a deprecation notice. Here are some examples:

@bt4ibwem8 bt4ibwem8 requested a review from z-Fng March 6, 2026 21:00
Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, did you push the latest changes to origin?

Since Scoop does not yet support automatic manifest replacement, we should keep the original manifest for a few months and include a deprecation notice. Here are some examples:

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

Walkthrough

Added deprecation metadata and messaging to bucket/open-tv.json and renamed a launcher label from "Open TV" to "Fred TV" in both bucket/open-tv.json and bucket/fred-tv.json. No other structural or behavioral changes detected.

Changes

Cohort / File(s) Summary
Deprecation & metadata
bucket/open-tv.json
Added top-level deprecation metadata (removal date and messaging), updated description and notes to indicate deprecation and replacement, added suggest mapping, preserved existing 64bit URL and hash, renamed shortcut label to "Fred TV".
Label-only update
bucket/fred-tv.json
Changed shortcut label from "Open TV" to "Fred TV" — no other structural or behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through manifests, quick and spry,
I nudged a name beneath the sky,
"Open" became a friend called Fred,
A tiny change before bed 💤📺

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description 'the project was renamed' is extremely vague and lacks required information per the template, such as issue reference, conventional PR format compliance checkbox, or contributing guide acknowledgment. Add proper PR description following the template: include issue reference (Closes/Relates to #XXXX), confirm conventional title format, and acknowledge reading the Contributing Guide.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'open-tv: Rename to fred-tv' clearly describes the main change: renaming the open-tv manifest to fred-tv.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bt4ibwem8
Copy link
Contributor Author

bt4ibwem8 commented Mar 7, 2026

Did you forget to push?

i clicked on "update branch", is it ok now? i am a newbie on this... or can you do it instead of me?

@z-Fng
Copy link
Member

z-Fng commented Mar 7, 2026

Just checking, did you push the latest changes to origin?

Since Scoop does not yet support automatic manifest replacement, we should keep the original manifest for a few months and include a deprecation notice. Here are some examples:

What I mean is that I recommend you recreate a new manifest named fred-tv.json as shown in the examples I provided, and include a deprecation notice in the open-tv manifest. Since you simply renamed the manifest, users who have already installed open-tv will not receive later updates without any notification.

@z-Fng
Copy link
Member

z-Fng commented Mar 8, 2026

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

All changes look good.

Wait for review from human collaborators.

fred-tv

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

open-tv

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/open-tv.json (1)

7-18: Add the manual migration command to the deprecation note.

This tells users what to install next, but not how to move off the deprecated manifest. Since open-tv is intentionally staying around for a grace period, make the note explicit with the uninstall/install step so users don't remain on the old manifest until removal.

Suggested tweak
     "notes": [
         "`open-tv` has been renamed to `fred-tv`.",
-        "This manifest is deprecated and scheduled for removal on 2026-09-01. Please use `extras/fred-tv` instead."
+        "This manifest is deprecated and scheduled for removal on 2026-09-01.",
+        "To migrate, run: `scoop uninstall open-tv` and then `scoop install extras/fred-tv`."
     ],
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/open-tv.json` around lines 7 - 18, Update the "notes" entry for the
deprecated manifest to include an explicit manual migration command so users
know how to move from "open-tv" to "extras/fred-tv"; specifically, append a line
to the notes array that shows the uninstall/install step (referencing "open-tv"
and "extras/fred-tv") with the package commands your project uses (e.g., replace
with the project's package manager syntax: uninstall open-tv then install
extras/fred-tv), and keep the existing deprecation message and removal date
intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/open-tv.json`:
- Around line 27-30: The manifest's shortcuts array currently uses the display
name "Fred TV" which duplicates bucket/fred-tv.json and hides that this package
is deprecated; update the shortcuts entry for "open_tv.exe" in open-tv.json to a
visually distinct label such as "Open TV (deprecated)" or "Open TV — legacy" so
users can easily tell this is the old package during the transition window.

---

Nitpick comments:
In `@bucket/open-tv.json`:
- Around line 7-18: Update the "notes" entry for the deprecated manifest to
include an explicit manual migration command so users know how to move from
"open-tv" to "extras/fred-tv"; specifically, append a line to the notes array
that shows the uninstall/install step (referencing "open-tv" and
"extras/fred-tv") with the package commands your project uses (e.g., replace
with the project's package manager syntax: uninstall open-tv then install
extras/fred-tv), and keep the existing deprecation message and removal date
intact.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c110d9b8-5486-42ce-9ac9-5f760cb7f4ba

📥 Commits

Reviewing files that changed from the base of the PR and between 518f200 and bd40e12.

📒 Files selected for processing (1)
  • bucket/open-tv.json

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Please make sure to follow the Contributing Guide and use conventional PR title next time.

Thanks for your contribution!

@z-Fng z-Fng merged commit f886a2c into ScoopInstaller:master Mar 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants