Skip to content

azurestorageexplorer: Fix download & autoupdate URLs#17356

Merged
z-Fng merged 1 commit intoScoopInstaller:masterfrom
dgrodziak:master
Mar 6, 2026
Merged

azurestorageexplorer: Fix download & autoupdate URLs#17356
z-Fng merged 1 commit intoScoopInstaller:masterfrom
dgrodziak:master

Conversation

@dgrodziak
Copy link
Contributor

@dgrodziak dgrodziak commented Mar 5, 2026

Closes #17354
Relates to microsoft/AzureStorageExplorer#8963

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated download and auto-update URLs to consistently include a "v" prefix in version paths for both 64-bit and arm64 releases, ensuring uniform download behavior.

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

Walkthrough

Updated Azure Storage Explorer manifest URLs to add a missing "v" prefix in release download and autoupdate paths (e.g., 1.41.1 -> v1.41.1).

Changes

Cohort / File(s) Summary
URL fixes
bucket/azurestorageexplorer.json
Replaced download URLs to include v prefix (e.g., .../releases/download/1.41.1/....../releases/download/v1.41.1/...) and updated autoupdate URLs to use /v$version/.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 I found a tiny missing "v",
Lost in URLs beneath a tree.
I nudged it in, the links took flight,
Downloads now land — what pure delight! 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the package and version being updated and describes the main fix applied to the manifest file.
Linked Issues check ✅ Passed The code changes directly address the linked issue #17354 by adding the missing 'v' prefix to download URLs in the manifest.
Out of Scope Changes check ✅ Passed All changes in the manifest are scoped to fixing the URL issue identified in #17354; no extraneous modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description includes required items: closes reference (#17354), conventional title format followed, and contributor confirms reading Contributing Guide.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

azurestorageexplorer

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
bucket/azurestorageexplorer.json (1)

27-34: ⚠️ Potential issue | 🟡 Minor

Autoupdate templates must use the v tag prefix for correct GitHub release URLs.

The autoupdate URLs on lines 30 and 33 use $version without the v prefix. Microsoft's AzureStorageExplorer repository uses v-prefixed release tags (e.g., v1.40.2), so the URLs should be https://github.com/microsoft/AzureStorageExplorer/releases/download/v$version/... to match the actual release asset paths. Without this correction, future automated updates will generate broken URLs.

🔧 Suggested patch
     "autoupdate": {
         "architecture": {
             "64bit": {
-                "url": "https://github.com/microsoft/AzureStorageExplorer/releases/download/$version/StorageExplorer-windows-x64.exe"
+                "url": "https://github.com/microsoft/AzureStorageExplorer/releases/download/v$version/StorageExplorer-windows-x64.exe"
             },
             "arm64": {
-                "url": "https://github.com/microsoft/AzureStorageExplorer/releases/download/$version/StorageExplorer-windows-arm64.exe"
+                "url": "https://github.com/microsoft/AzureStorageExplorer/releases/download/v$version/StorageExplorer-windows-arm64.exe"
             }
         }
     }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/azurestorageexplorer.json` around lines 27 - 34, The autoupdate URL
templates under the "autoupdate" -> "architecture" entries (keys "64bit" and
"arm64" with "url" fields) are missing the required 'v' prefix for GitHub
release tags; update those "url" templates to insert a 'v' before $version
(i.e., use v$version) so the generated release download URLs match the
repository's v-prefixed tags.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@bucket/azurestorageexplorer.json`:
- Around line 27-34: The autoupdate URL templates under the "autoupdate" ->
"architecture" entries (keys "64bit" and "arm64" with "url" fields) are missing
the required 'v' prefix for GitHub release tags; update those "url" templates to
insert a 'v' before $version (i.e., use v$version) so the generated release
download URLs match the repository's v-prefixed tags.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0eb3522-039e-4f5c-a9be-4bc0d16bfef2

📥 Commits

Reviewing files that changed from the base of the PR and between e2e3aaf and ce22cbd.

📒 Files selected for processing (1)
  • bucket/azurestorageexplorer.json

@dgrodziak
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

azurestorageexplorer

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@dgrodziak
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

All changes look good.

Wait for review from human collaborators.

azurestorageexplorer

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title azurestorageexplorer@1.41.1: Fixes url (Closes #17354) azurestorageexplorer: Fix download & autoupdate URLs Mar 6, 2026
Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 264c8e5 into ScoopInstaller:master Mar 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurestorageexplorer@1.41.1: download via aria2 failed

2 participants