azurestorageexplorer: Fix download & autoupdate URLs#17356
azurestorageexplorer: Fix download & autoupdate URLs#17356z-Fng merged 1 commit intoScoopInstaller:masterfrom
Conversation
WalkthroughUpdated Azure Storage Explorer manifest URLs to add a missing "v" prefix in release download and autoupdate paths (e.g., Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with azurestorageexplorer
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bucket/azurestorageexplorer.json (1)
27-34:⚠️ Potential issue | 🟡 MinorAutoupdate templates must use the
vtag prefix for correct GitHub release URLs.The autoupdate URLs on lines 30 and 33 use
$versionwithout thevprefix. Microsoft's AzureStorageExplorer repository uses v-prefixed release tags (e.g.,v1.40.2), so the URLs should behttps://github.com/microsoft/AzureStorageExplorer/releases/download/v$version/...to match the actual release asset paths. Without this correction, future automated updates will generate broken URLs.🔧 Suggested patch
"autoupdate": { "architecture": { "64bit": { - "url": "https://github.com/microsoft/AzureStorageExplorer/releases/download/$version/StorageExplorer-windows-x64.exe" + "url": "https://github.com/microsoft/AzureStorageExplorer/releases/download/v$version/StorageExplorer-windows-x64.exe" }, "arm64": { - "url": "https://github.com/microsoft/AzureStorageExplorer/releases/download/$version/StorageExplorer-windows-arm64.exe" + "url": "https://github.com/microsoft/AzureStorageExplorer/releases/download/v$version/StorageExplorer-windows-arm64.exe" } } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/azurestorageexplorer.json` around lines 27 - 34, The autoupdate URL templates under the "autoupdate" -> "architecture" entries (keys "64bit" and "arm64" with "url" fields) are missing the required 'v' prefix for GitHub release tags; update those "url" templates to insert a 'v' before $version (i.e., use v$version) so the generated release download URLs match the repository's v-prefixed tags.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@bucket/azurestorageexplorer.json`:
- Around line 27-34: The autoupdate URL templates under the "autoupdate" ->
"architecture" entries (keys "64bit" and "arm64" with "url" fields) are missing
the required 'v' prefix for GitHub release tags; update those "url" templates to
insert a 'v' before $version (i.e., use v$version) so the generated release
download URLs match the repository's v-prefixed tags.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a0eb3522-039e-4f5c-a9be-4bc0d16bfef2
📒 Files selected for processing (1)
bucket/azurestorageexplorer.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with azurestorageexplorer
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. azurestorageexplorer
|
Closes #17354
Relates to microsoft/AzureStorageExplorer#8963
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit