Skip to content

keynavish: Add version 1.7.0#17351

Merged
z-Fng merged 4 commits intoScoopInstaller:masterfrom
snowman:add-keynavish
Mar 5, 2026
Merged

keynavish: Add version 1.7.0#17351
z-Fng merged 4 commits intoScoopInstaller:masterfrom
snowman:add-keynavish

Conversation

@snowman
Copy link
Contributor

@snowman snowman commented Mar 5, 2026

Closes #17350

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Added a Windows installer with both 32‑ and 64‑bit packages.
    • Installer places executable shims and creates desktop/start-menu shortcuts.
    • Ensures a user configuration file is created and persisted across reinstalls and updates.
    • Built‑in automatic update checks tied to GitHub releases for seamless version upgrades.

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2b91195c-698a-46b8-8391-9f34e8384c15

📥 Commits

Reviewing files that changed from the base of the PR and between 73f92ec and 155efc6.

📒 Files selected for processing (1)
  • bucket/keynavish.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/keynavish.json

Walkthrough

Adds a new Scoop manifest bucket/keynavish.json for Keynavish v1.7.0 with metadata, architecture-specific download URLs and hashes, a PowerShell pre_install, bin/shortcuts/persist entries, and GitHub-based checkver/autoupdate.

Changes

Cohort / File(s) Summary
Scoop manifest
bucket/keynavish.json
New Scoop manifest for Keynavish v1.7.0: package metadata (version, description, homepage, license), 64-bit/32-bit url + hash, a pre_install PowerShell script to ensure keynavrc, bin and shortcuts, persist for keynavrc, checkver: github, and autoupdate URLs parameterized by version.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰
I hopped in with a manifest bright,
URLs, hashes, all set right.
A config kept, shortcuts clear,
Keynavish installed with cheer. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'keynavish: Add version 1.7.0' clearly identifies the manifest being modified and the version being added, following the conventional format specified in the repository template.
Description check ✅ Passed The pull request description includes the required conventional PR title format and confirmation of reading the Contributing Guide, meeting the template requirements.
Linked Issues check ✅ Passed The code changes implement all requirements from issue #17350: adds a Scoop manifest for keynavish with correct version 1.7.0, architecture support, proper metadata, and installation configuration matching the requested package specifications.
Out of Scope Changes check ✅ Passed The pull request contains only the new bucket/keynavish.json manifest file, which is directly in scope for fulfilling issue #17350's request to add keynavish to the Scoop repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

All changes look good.

Wait for review from human collaborators.

keynavish

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/keynavish.json`:
- Around line 33-36: The autoupdate download URLs for the "64bit" and "32bit"
entries in keynavish.json currently point to versioned filenames
(keynavish-v$version-x86_64.exe and keynavish-v$version-x86.exe) but are missing
the fragment that renames the file to the expected shim name; update the "url"
values for the 64bit and 32bit keys to append "#/keynavish.exe" (matching the
other architecture entries) so the downloaded file is renamed to keynavish.exe
during autoupdate and shim creation succeeds.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f5ead864-79a4-40ae-a46c-7b61226f1b69

📥 Commits

Reviewing files that changed from the base of the PR and between d0bc3b4 and 8644bb3.

📒 Files selected for processing (1)
  • bucket/keynavish.json

@z-Fng
Copy link
Member

z-Fng commented Mar 5, 2026

@z-Fng
Copy link
Member

z-Fng commented Mar 5, 2026

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

All changes look good.

Wait for review from human collaborators.

keynavish

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 46be811 into ScoopInstaller:master Mar 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: keynavish

2 participants