keepassprotectedkeystore: Add version 1.4.0#17349
keepassprotectedkeystore: Add version 1.4.0#17349KoltesDigital wants to merge 1 commit intoScoopInstaller:masterfrom
Conversation
WalkthroughAdds a new Scoop manifest for the KeePassProtectedKeyStore plugin (v1.4.0) including metadata, source and hash, PowerShell installer/uninstaller scripts, optional post_uninstall purge, GitHub version check, and autoupdate URL templating. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. keepass-plugin-keepassprotectedkeystore
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/keepass-plugin-keepassprotectedkeystore.json`:
- Around line 10-17: The lifecycle scripts are not defensive: update the
"script" that runs Copy-Item (KeePassProtectedKeyStore.dll) to include -Force so
upgrades can overwrite, update the uninstaller Remove-Item call to include
-Force -ErrorAction SilentlyContinue so missing files don't error, and change
the post_uninstall block that currently does Remove-Item
"$env:LOCALAPPDATA\CSquared167\KeePassProtectedKeyStore" -Recurse -Force by
first wrapping it in a Test-Path check (e.g. if (Test-Path <path>) { Remove-Item
... }) to avoid errors when the directory doesn't exist; locate these changes in
the JSON keys "script", "uninstaller" (script) and "post_uninstall" where $purge
is tested.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0c28cbb3-4f18-4cfd-a2d6-c7f38d94cfa3
📒 Files selected for processing (1)
bucket/keepass-plugin-keepassprotectedkeystore.json
|
To add a new package to this bucket, please follow the standard way to create a package request issue first and link it to your PR. When creating a package request, you can check the criteria for a package to be accepted in this bucket, which can help you determine whether your PR is likely to be approved. The information provided in the issue can also help maintainers quickly get the necessary details.
|
|
Thanks for your contribution! However, it appears that your package request doesn't fully meet the essential criteria. Please feel free to reopen this PR once it fully meets the criteria, or consider creating your own bucket instead. |
|
@z-Fng Thanks for the answer. I already followed the standard way for another package and it was totally ignored. ScoopInstaller/Main#5602 If by "doesn't fully meet the essential criteria" you mean "less than 100 stars on GH", well https://github.com/fireout/keepasssequencer isn't so popular neither but has its manifest. Well maybe KeePass plugins need their own bucket. |
We probably forgot to close it, not that it was ignored.
It seems to be added quite some time ago. Things are different now. Given that Scoop is currently entirely community-driven with only a handful of active maintainers, keeping up with the thousands of existing manifests is already challenging. Without an acceptance criteria, we'd be overwhelmed by issues and pull requests. |
|
Agreed, maintaining this beast is a tedious chore. Auto-update has been a relieving design, but still. Would you advise, as an individual or organization, to have our own bucket with all the manifests we rely on, even though that would mean duplicating some from other public buckets, or only with the manifests that no other buckets offer? Hopefully with auto-update, duplicated manifests would converge to the same content. Surely for orgs it would be safer to manually review updates within their own buckets. |
Adds
keepass-plugin-keepassprotectedkeystore, a plugin for KeePass 2.x that uses the computer's Trusted Platform Module (TPM) hardware to create protected key stores.I had a headache deciding what to do with user data. The plugin stores stuff in hardcoded AppData/Local/..., so I've tried to make a Junction, or to copy files back and forth with
$persist_dirduringpre_[un]install. But ultimately, I think just clearing AppData when$purged does the same behavior.<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit