miro-pdf: Add version 0.7.3#17256
Open
Assad-AC wants to merge 3 commits intoScoopInstaller:masterfrom
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughAdds a new Scoop manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All changes look good. Wait for review from human collaborators. miro-pdf
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/miro-pdf.json`:
- Around line 6-12: The "notes" array contains a broken split sentence and a
redundant entry; update the "notes" element(s) so the configuration path and
parenthetical are a single, correct sentence matching upstream: replace the
fragmented entries with one string exactly stating "The configuration file is
located at ~/.config/miro-pdf/miro.conf (or .config/miro-pdf/miro.conf in the
home directory of your operating system)." and remove any duplicate or
trailing-space entries so the "notes" array contains no redundant lines.
In response to auto-review
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@bucket/miro-pdf.json`:
- Around line 6-12: Update the "notes" array in miro-pdf.json: merge the split
sentence currently in the two elements ("User data..." and "in the home
directory...") into a single, correct sentence that uses "The configuration
file" as the subject, remove the verbose/redundant element that restates the
same location, and delete the trailing empty string element; make the final text
match the upstream README phrasing: "The configuration file is located at
~/.config/miro-pdf/miro.conf (or .config/miro-pdf/miro.conf in the home
directory of your operating system)." Ensure you edit the "notes" array entry in
the file to reflect this single clean sentence.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/miro-pdf.json`:
- Line 3: The package description currently claims support for "macOS" but
upstream provides no macOS binaries; update the "description" field in
miro-pdf.json to remove or rephrase the macOS claim so it accurately reflects
that only Windows binaries are shipped (e.g., mention native PDF viewer for
Windows with source builds for other platforms), by editing the "description"
JSON value to match the releases and upstream note.
---
Duplicate comments:
In `@bucket/miro-pdf.json`:
- Around line 6-12: The "notes" array contains redundant, broken and
trailing-space text; replace its entries so the single coherent sentence matches
upstream: set the "notes" array to one string exactly stating that the
configuration file is located at "~/.config/miro-pdf/miro.conf (or
.config/miro-pdf/miro.conf in the home directory of your operating system)".
Locate the "notes" key in this JSON and remove extra empty strings, duplicated
phrasing, and trailing spaces so only the corrected sentence remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the manifest for Miro, for which I have verified that auto-updating works on my local machine with checkver.ps1. Note that while the name of the software is Miro, Miro-PDF is the clearer identifier that is used for installation and the name of the executable.
Closes #17230
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit