PR: Add optional agentId to ruleTrigger for easy filtering on UI

[visagang]

No description provided.

[qodo-code-review]

Review Summary by Qodo

Add optional agentId filtering to rule triggers for UI display

✨ Enhancement

Walkthroughs

Description

• Add optional AgentIds property to IRuleTrigger interface for UI filtering
• Implement new endpoint to retrieve rule triggers filtered by agent ID
• Support backward compatibility with triggers having no agent associations

Diagram

flowchart LR
  A["IRuleTrigger Interface"] -->|"Add AgentIds property"| B["AgentIds: string[]?"]
  C["AgentController"] -->|"New endpoint"| D["GET /rule/triggers/{agentId}"]
  D -->|"Filter by AgentIds"| E["Filtered RuleViewModel List"]

Loading

File Changes

1. src/Infrastructure/BotSharp.Abstraction/Rules/IRuleTrigger.cs ✨ Enhancement +6/-0

Add optional AgentIds property to interface

• Added optional AgentIds property to IRuleTrigger interface
• Property defaults to null for backward compatibility
• Documented as UI display/filtering only, not used in execution logic

src/Infrastructure/BotSharp.Abstraction/Rules/IRuleTrigger.cs

---

2. src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs ✨ Enhancement +14/-0

Add agent-filtered rule triggers endpoint

• Added new GetRuleTriggers(string agentId) endpoint with route /rule/triggers/{agentId}
• Filters triggers by agent ID with null-safe logic supporting triggers without agent associations
• Returns filtered AgentRuleViewModel list ordered by trigger name
• Maintains existing GetRuleTriggers() endpoint for retrieving all triggers

src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. AgentIds.Contains is case-sensitive ☑ 📘 Rule violation ≡ Correctness

Description

The new filtering endpoint uses x.AgentIds.Contains(agentId) which performs a case-sensitive
identifier comparison by default. This can cause incorrect trigger matching for identifier-like
strings and violates the requirement to use ordinal, case-insensitive comparisons.

Code

src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs[R11-12]

+        var triggers = _services.GetServices<IRuleTrigger>();
+        triggers = triggers.Where(x => x.AgentIds == null || !x.AgentIds.Any() || x.AgentIds.Contains(agentId));

Evidence

PR Compliance ID 4 requires ordinal, case-insensitive matching for identifier-like strings; the
added code filters by agentId using Contains without StringComparer.OrdinalIgnoreCase, making
matching case-sensitive.

src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs[11-12]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new endpoint filters triggers using `x.AgentIds.Contains(agentId)` which is case-sensitive by default. Identifier-like matches must use ordinal, case-insensitive comparisons.
## Issue Context
Route parameter `agentId` is an identifier and should match regardless of casing.
## Fix Focus Areas
- src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs[11-12]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. agentId lacks null guard ☑ 📘 Rule violation ☼ Reliability

Description

The new API boundary method GetRuleTriggers(string agentId) does not validate agentId for
null/empty/whitespace before using it for filtering. This reduces resilience and does not meet the
requirement to add explicit null/empty guards with a safe fallback and clear logging.

Code

src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs[R9-12]

+    public IEnumerable<AgentRuleViewModel> GetRuleTriggers(string agentId)
+    {
+        var triggers = _services.GetServices<IRuleTrigger>();
+        triggers = triggers.Where(x => x.AgentIds == null || !x.AgentIds.Any() || x.AgentIds.Contains(agentId));

Evidence

PR Compliance ID 2 requires explicit null/empty guards at API boundaries with safe fallback and
clear logging; the added endpoint accepts agentId and immediately applies it in filtering logic
with no guard or log path for invalid input.

src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs[9-12]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new `GetRuleTriggers(string agentId)` endpoint does not guard against null/empty/whitespace `agentId` values, and it provides no safe fallback behavior with clear logging.
## Issue Context
This is an API boundary (`HttpGet("/rule/triggers/{agentId}")`), so it should validate inputs before applying filtering.
## Fix Focus Areas
- src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs[9-12]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[Oceania2018]

Should remove || !x.AgentIds.Any()