Tests: AMDA cassette migration (unit tier)#293
Open
jeandet wants to merge 51 commits into
Open
Conversation
Captures decisions on UV adoption, hatchling build backend, ruff/basedpyright tooling, and three-tier test strategy (unit/contract/e2e). Sequences the work as 17 small PRs ending with a mass reformat. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Per-task implementation plan for the first PR of the modernisation effort. Covers pyproject.toml updates, uv.lock generation, CI/RTD switch to uv, deletion of requirements*.txt / tox.ini / setup.cfg, and developer-doc updates to drop the PYTHONPATH=. pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add SPEASY_CORE_HTTP_REWRITE_RULES env to PRs.yml non-3.10 pytest step (previously only on push/scheduled tests.yml — would have hit a non-existent server on PR builds for non-3.10 matrix entries). - Add --with wheel to PRs.yml build step for parity with tests.yml. - Scope flake8 to 'speasy tests' in both workflows (matches Makefile lint target). Avoids silently broadening lint to docs/conf.py and removes the .venv exclusion workaround that was needed when flake8 ran from repo root.
Without UV_PROJECT_ENVIRONMENT, uv creates .venv/ inside the project and RTD's sphinx step (which calls $READTHEDOCS_VIRTUALENV_PATH/bin/python directly) fails with 'python: not found'. Point uv at RTD's venv so the install lands where the runner looks for it.
Classified via devtools/apply_test_markers.py: - 12 files marked unit (pure-logic, no network) - 19 files marked contract (real-server, will be migrated to cassettes in PRs 4-9) Reclassifications during manual review: - test_cache.py: contract -> unit (pure cache-logic, no network or speasy provider use) - test_file_access.py: unit -> contract (uses HTTP via any_loc_open against live servers) test_wasm.py was manually adjusted to place pytestmark at module level (the file's body lives inside a try/except ImportError block, so the script's naive insertion landed at wrong indentation).
…le path and sample across the inventory The flat_inventories.generic_archive lookup uses module attribute access on an instance, not a submodule import. Also, the first N parameters in the flat inventory are clustered by mission, so a fixed time range can miss all of them; sample across the full list instead.
- test_e2e_smoke.test_generic_archive: fail loudly if every candidate raises (was silently skipping, defeating the e2e tier's purpose). - pyproject.toml: drop dead --ignore=setup.py from addopts and document the -m unit override semantics so future contributors don't trip on 'pytest tests/test_amda.py' silently collecting nothing. - contract.yml / e2e.yml: add concurrency groups so a manual run can't overlap with a cron run hammering the same upstream servers. - CONTRIBUTING.rst: add a short note explaining the three test tiers and how to invoke each from local dev.
CI failure (blocking): - unit.yml: 'make doctest' was using system Python (no sphinx in scope). Prefix with 'uv run' so make uses the project venv. Reviewer findings: - wasm_tests.yml: pytest tests/test_wasm.py without -m collected 0 tests under the new addopts default (test_wasm.py is contract-marked). Add -m '' to override. - CLAUDE.md: examples like 'uv run pytest tests/test_amda.py' silently collected 0 tests under -m unit default. Replaced with tier-aware examples and added -m '' for the all-tests case. - unit.yml: only sync --group docs on the coverage runner that needs it, not on every matrix entry.
nbsphinx requires the system pandoc binary (not the Python pandoc wrapper that's in the docs dependency group). PR 1's tests.yml had 'sudo apt install -y texlive pandoc' before make doctest; my unit.yml rewrite in PR 2 dropped that line, so the doctest job failed with 'nbsphinx.NotebookError: PandocMissing in examples/AMDA.ipynb'. Restored as a separate apt step on the coverage runner.
The doctest step's examples reference all data providers (cdpp3dview included) and live inventories. The job-level SPEASY_CORE_DISABLED_PROVIDERS='cdpp3dview' makes the inventory tree's cdpp3dview attribute missing during doctest, surfacing as 'types.SimpleNamespace object has no attribute cdpp3dview' and a chain of NameErrors for variables defined in earlier doctest blocks. Original tests.yml overrode SPEASY_CORE_DISABLED_PROVIDERS="" on the combined pytest+doctest step, plus set HTTP_REWRITE_RULES (re-routes the placeholder URL used in some examples to LPP's mirror) and USER_AGENT. My PR 2 rewrite dropped the env block; restoring it on the doctest step.
Pandas now prints its public name in type() repr ('pandas.DataFrame')
rather than the internal module path ('pandas.core.frame.DataFrame').
The user/numpy.rst doctest was written against the old form.
Surfaced now that uv.lock pins a recent pandas; pip-installed envs
were getting older pandas where the old form still applied.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if any("import pytest" in ln for ln in lines): | ||
| block = [f"\n{MARKER_LINE_PREFIX}{tier}\n", "\n"] | ||
| lines[insert_at:insert_at] = block | ||
| path.write_text("".join(lines)) |
This was referenced May 11, 2026
Two infrastructure fixes that originally surfaced during PR 5 (CDA) and PR 9 (CDPP3DView) cassette migrations, backported here where they belong: 1. speasy/core/http.py Response.url: try/except AttributeError fallback for vcrpy's VCRHTTPResponse which delegates geturl() to http.client that reads self.url — an attribute the cassette response doesn't carry. Without this, every cassette-replayed response that triggers a debug-log of resp.url crashes. 2. tests/conftest.py _canonical_rewrite_rule_for_vcr autouse fixture: Pin speasy.core.url_utils._REWRITE_RULES_ (cached at module import time) to the recording-time policy for any vcr-marked test. Without this, a developer with a custom http_rewrite_rules entry in ~/.config/speasy/config.ini sees replay failures because the replay-side URL no longer matches the cassette.
jeandet
force-pushed
the
modernisation/pr4-amda-cassettes
branch
from
618e2e6 to
8c72662
Compare
vcrpy's filter_headers and filter_query_parameters only scrub the REQUEST side. Response headers like Set-Cookie (JSESSIONIDs from CSA, session tokens from AMDA) and certain response bodies (AMDA's auth.php returns a 32-char hex hash that may be derivable from credentials) were being committed verbatim into cassettes. Add before_record_response callback in vcr_config: - Drops Set-Cookie response headers - Replaces any 32-char hex body (matching AMDA auth.php response shape) with <SCRUBBED> This guards future recordings. Existing cassettes are scrubbed in a follow-up one-shot script (see PR description).
Sister script to the new before_record_response callback in conftest. Scrubs the same patterns (Set-Cookie response headers, 32-char hex auth.php response bodies) from cassettes that were recorded before the callback existed. Idempotent — safe to re-run. Used once to retroactively clean the existing AMDA + CSA cassettes on the modernisation/pr3-mocking-infra branch. Future recordings are automatically scrubbed at record time by the conftest callback.
jeandet
force-pushed
the
modernisation/pr4-amda-cassettes
branch
from
8c72662 to
038b747
Compare
The cassette hosting at sciqlop.lpp.polytechnique.fr/data/speasy_cassettes/ is now public-read. Cassettes are content-addressed by sha256 — URLs are unguessable for outsiders and any tampering is caught on download via the existing hash verification in _fetch_cassette. Practical benefits: - Fork PRs can run the cassette-replaying unit tier (previously blocked: GitHub Actions doesn't expose repo secrets to fork PRs). - New contributors need no credential setup to run the tests. - CI workflows lose the SPEASY_CASSETTE_FETCH_USER/PASSWORD env injection (no longer needed). Cassettes are still scrubbed (Set-Cookie response headers and AMDA auth.php hash response bodies) by the before_record_response callback in vcr_config, so no session/credential material reaches the cassette content itself.
jeandet
force-pushed
the
modernisation/pr4-amda-cassettes
branch
from
038b747 to
905e283
Compare
The conftest is imported by every pytest run, including the wasm_tests.yml workflow that uses a minimal Python env (it installs pytest-pyodide but not the project's full dev group). numpy is only needed by the speasy_variable_factory fixture's _make closure; importing it at module level breaks wasm test collection with ModuleNotFoundError. Move the import inside the fixture body so non-unit-tier callers don't need it.
jeandet
force-pushed
the
modernisation/pr4-amda-cassettes
branch
from
6429e2a to
7c5ac5e
Compare
Same rationale as numpy: the wasm_tests.yml workflow uses a minimal Python env that doesn't install requests (only pyodide-py and pytest-pyodide). Importing requests at conftest module level breaks wasm test collection. Moved inside _fetch_cassette so non-fetching callers don't need it.
jeandet
force-pushed
the
modernisation/pr4-amda-cassettes
branch
from
7c5ac5e to
1357ee8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
===========================================
- Coverage 85.10% 72.60% -12.51%
===========================================
Files 69 82 +13
Lines 4834 5092 +258
Branches 668 693 +25
===========================================
- Hits 4114 3697 -417
- Misses 479 1174 +695
+ Partials 241 221 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The wasm test runs in a minimal Python env that doesn't install 'requests'. The conftest's pytest_configure hook calls _fetch_cassette (which lazily imports requests); on this env the import fails and INTERNALERROR's the run. Wasm tests don't replay cassettes anyway — just skip the fetch via the existing --no-cassette-fetch flag.
Generated by devtools/publish_cassettes.py from cassettes recorded
against live amda.irap.omp.eu. Each entry maps a relative path under
tests/cassettes/ to the sha256 of the cassette's uncompressed YAML
content. The .yaml.gz files for these hashes need to be uploaded by
a maintainer to:
https://sciqlop.lpp.polytechnique.fr/data/speasy_cassettes/
via rsync from .publish_staging/. After upload, the conftest fetch
hook will download cassettes on demand for unit-tier test runs that
hit AMDA code paths.
Total: 90.6 MB uncompressed, 10.9 MB compressed across 22 cassettes.
The original recording captured a HEAD if-modified-since request to spdf.gsfc.nasa.gov/pub/catalogs/all.xml because Speasy's diskcache was already warm at recording time. On replay with a clean cache, Speasy issues a full GET which has no matching cassette entry, failing with CannotOverwriteExistingCassetteException. Re-recorded with SPEASY_CACHE_PATH set to a fresh tempdir (the pattern PR 5 established) so the cassette captures the GET path. The 50 MB cassette content is the full AMDA observatory tree.
The scrub_existing_cassettes.py one-off removed Set-Cookie response headers and replaced AMDA auth.php response bodies (32-char hex session tokens) with <SCRUBBED>. Content-addressed cassette hashes changed for the affected files; manifest updated to match.
The earlier re-record only cleared SPEASY_CACHE_PATH but kept the populated SPEASY_INDEX_PATH (Speasy's index path is separate from the cache). With a populated index, Speasy's catalog-loader sees the inventory as 'already known' and issues HEAD if-modified-since revalidations instead of the full GETs that a fresh-state install does. Result: cassette captured HEAD only; CI (fresh state) issues GET and fails to match. Re-recorded with both SPEASY_CACHE_PATH and SPEASY_INDEX_PATH set to fresh tempdirs so the catalog GETs are captured.
jeandet
force-pushed
the
modernisation/pr4-amda-cassettes
branch
from
1357ee8 to
342ca29
Compare
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fourth PR of the modernisation effort (spec:
docs/superpowers/specs/2026-05-08-speasy-modernisation-design.md, plan:docs/superpowers/plans/2026-05-10-pr4-amda-cassettes.md). First of the per-provider cassette migrations.Stacked on PR #292 (mocking infrastructure with cassette-storage tooling), which stacks on #291 (markers) and #290 (UV foundation). This PR's diff includes them all until they merge in order.
What this PR does
test_amda.py,test_amda_parameter.py,test_amda_catalog.py,test_amda_timetable.py— 65 tests total) from the contract tier to the unit tier with cassette-backed replay.amda.irap.omp.eu), uploads them tohttps://sciqlop.lpp.polytechnique.fr/data/speasy_cassettes/(HTTP Basic-protected, hash-addressed gzip blobs), and commits the manifest entries.tests/test_amda_contract.py(5 daily-cron drift probes).tests/test_amda_failures.py(1 failure-path unit test using mocking).devtools/apply_test_markers.pyCLASSIFICATIONdict.Storage approach
Cassettes are NOT committed to the git repo. They live on sciqlop.lpp behind HTTP Basic auth.
tests/conftest.py'spytest_configurehook (added in PR #292) readstests/cassettes_manifest.json, fetches missing cassettes by content hash, caches them under~/.cache/speasy-tests/, and decompresses them totests/cassettes/before tests run. CI usesSPEASY_CASSETTE_FETCH_USER/SPEASY_CASSETTE_FETCH_PASSWORDGitHub secrets.Net effect
Test plan
unit.ymlgreen — AMDA tests now replay from cassettes fetched at session startcontract.yml(manually triggered) — 5 AMDA probes pass against real upstream