Conversation
Collaborator
|
I think this should be a breaking version, so that we can make it so ArrayInterface versions with ranges are incompatible with Static version with ranges. |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 99.36% 99.09% -0.28%
==========================================
Files 2 3 +1
Lines 472 662 +190
==========================================
+ Hits 469 656 +187
- Misses 3 6 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Tokazama
added a commit
to JuliaArrays/ArrayInterface.jl
that referenced
this pull request
Nov 7, 2022
This is complimentary to SciML/Static.jl#88 and would be a big move in disentangling static types from ArrayInterface
This replaces the concept of "canonical" integers in ArrayInterface so we can also move that functionality here.
Collaborator
Author
|
@chriselrod and @ChrisRackauckas , this should be ready for review. |
ChrisRackauckas
approved these changes
Nov 15, 2022
Tokazama
added a commit
to JuliaArrays/ArrayInterface.jl
that referenced
this pull request
Nov 17, 2022
* Remove optionally static range types This is complimentary to SciML/Static.jl#88 and would be a big move in disentangling static types from ArrayInterface * Replace CanonicalInt with Static.IntType * Remove internal `_pick_range` method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to manually define a bit more to get this working outside of ArrayInterface (not
known_*traits) but it's probably better to avoid the type piracy we currently are doing withStaticIntrange constructors in downstream packaging.Solves #41