Runic-format test/qa/qa.jl (fix Format Check on main)#51
Merged
ChrisRackauckas merged 1 commit intoJun 17, 2026
Merged
Conversation
The Runic format check on main fails because `test/qa/qa.jl` (added in PR SciML#49) was not Runic-formatted. Reformat the multi-line `run_qa(...)` call to satisfy Runic 1.7.0. No behavior change. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the failing Runic / Runic Format Check on
main.test/qa/qa.jl(added in #49, the SciMLTesting v1.2 conversion) was committed without Runic formatting, so the centralizedrunic.ymlcheck fails onmain. This reformats the multi-linerun_qa(...)call to satisfy Runic 1.7.0.Diff
No behavior change.
Local verification
Ran Runic 1.7.0 on Julia 1.10 over every tracked
.jlfile in the repo:test/qa/qa.jlwas the only non-conformant file.ALL CLEAN: every tracked .jl file is Runic-conformant.Scope note
This PR fixes only the format check. The other red checks on
mainare separate, real issues and are not addressed here:local variable ΔHᵣ may be undefinedinProcessSimulator.var"#89#90".test/simple_cstr.jl:91-92fails numerically (Tmaxevaluates to297.0vs expected356.149), a real regression.UndefVarError: AbstractNonlinearTerminationMode not definedwhile precompilingDifferentialEquations/SteadyStateDiffEqat downgrade floors (dependency-floor breakage).Please ignore until reviewed by @ChrisRackauckas.