Skip to content

Runic-format test/qa/qa.jl (fix Format Check on main)#51

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:fix-runic-qa-format
Jun 17, 2026
Merged

Runic-format test/qa/qa.jl (fix Format Check on main)#51
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:fix-runic-qa-format

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

What

Fixes the failing Runic / Runic Format Check on main.

test/qa/qa.jl (added in #49, the SciMLTesting v1.2 conversion) was committed without Runic formatting, so the centralized runic.yml check fails on main. This reformats the multi-line run_qa(...) call to satisfy Runic 1.7.0.

Diff

-run_qa(ProcessSimulator; Aqua = Aqua, JET = JET, jet = true,
-    jet_kwargs = (; target_defined_modules = true))
+run_qa(
+    ProcessSimulator; Aqua = Aqua, JET = JET, jet = true,
+    jet_kwargs = (; target_defined_modules = true)
+)

No behavior change.

Local verification

Ran Runic 1.7.0 on Julia 1.10 over every tracked .jl file in the repo:

  • Before: test/qa/qa.jl was the only non-conformant file.
  • After: ALL CLEAN: every tracked .jl file is Runic-conformant.

Scope note

This PR fixes only the format check. The other red checks on main are separate, real issues and are not addressed here:

  • QA (JET) — JET reports a genuine code defect: local variable ΔHᵣ may be undefined in ProcessSimulator.var"#89#90".
  • Core (julia 1/lts/pre)test/simple_cstr.jl:91-92 fails numerically (Tmax evaluates to 297.0 vs expected 356.149), a real regression.
  • DowngradeUndefVarError: AbstractNonlinearTerminationMode not defined while precompiling DifferentialEquations/SteadyStateDiffEq at downgrade floors (dependency-floor breakage).

Please ignore until reviewed by @ChrisRackauckas.

The Runic format check on main fails because `test/qa/qa.jl` (added in
PR SciML#49) was not Runic-formatted. Reformat the multi-line `run_qa(...)`
call to satisfy Runic 1.7.0. No behavior change.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 17, 2026 10:29
@ChrisRackauckas ChrisRackauckas merged commit 7cad441 into SciML:main Jun 17, 2026
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants