Route umbrella QA group through the qa keyword (fixes GROUP=QA dispatch)#22
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Route umbrella QA group through the qa keyword (fixes GROUP=QA dispatch)#22ChrisRackauckas-Claude wants to merge 1 commit into
qa keyword (fixes GROUP=QA dispatch)#22ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
The root `test/runtests.jl` passed the QA (Aqua/JET) group via
`groups = Dict("QA" => ...)`, but "QA" is a reserved group name in
SciMLTesting's `run_tests`: it is dispatched to the `qa` keyword, not
through `groups`. With `qa` unset, `GROUP="QA"` hit
ArgumentError: run_tests: GROUP="QA" was requested but no `qa` body was provided
failing the `tests / QA` checks. Pass the group via `qa = (; env, body)`
so the reserved name is routed correctly.
Verified locally on Julia 1.12 (the `julia 1` matrix entry):
`GROUP=QA Pkg.test()` now runs the umbrella Aqua+JET suite to
"QA | 12 12" all-pass / "tests passed".
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Status update (CI triage 2026-06-20): the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
tests / QAchecks onmainfail with:The root
test/runtests.jlregistered the QA (Aqua/JET) group viagroups = Dict("QA" => (; env, body)). But"QA"is a reserved groupname in SciMLTesting's
run_tests: whenGROUP="QA", the dispatcherroutes to the
qakeyword body, not through thegroupstable. Withqaleft unset, the reserved-name branch throws theArgumentErrorabove.
Fix
Pass the QA group via the
qa = (; env, body)keyword instead ofgroups.No other behavior changes; the QA env/body are unchanged
(
test/qa/Project.toml+test/qa/qa.jl).Local verification
On Julia 1.12 (the
julia 1matrix entry),GROUP=QA Pkg.test()now runsthe umbrella Aqua+JET suite cleanly:
Runic check (
runic --check) passes on the edited file.Scope / remaining reds (not addressed here)
This PR fixes the
julia 1QA check. Othermainreds have differentroot causes and are out of scope for this focused PR:
tests / Core (julia lts)andtests / QA (julia lts)fail earlier, atjulia-buildpkg, withexpected package CanonicalMoments ... to be registered. On Julia 1.10 the[sources]table is not auto-resolved, andthe centralized
SciML/.githubtests.ymlskips its "Develop in-repo[sources]path deps" step whenproject == '.'— so a monorepo rootproject with in-repo
[sources]never gets its path deps developed on1.10. That is a
SciML/.githubworkflow bug, tracked separately.sublibraries / lib/OUQBase [QA]/lib/CanonicalMoments [QA]report realAqua/JET findings (stale dep
PolynomialRoots, a type-piracy onCanonicalMoments.RawMomentSequence, several JET errors). These are genuinecode findings, not harness bugs.
Downgrade/Downgrade Sublibrariesfail because the downgrade resolvercannot handle the unregistered in-repo
[sources]UUIDs.Please ignore until reviewed by @ChrisRackauckas.