Use SciMLTesting v1.2 (folder-based run_tests)#21
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Route the root test dispatcher through SciMLTesting v1.2. The sublibrary pre-step is preserved verbatim (the <1.11 transitive [sources] develop walk and the exact withenv/Pkg.test invocation), with the hand-rolled _detect_sublibrary_group closure replaced by SciMLTesting.detect_sublibrary_group (verified to return identical (sublibrary, test_group) pairs for every GROUP value). The root Core/All group now dispatches through run_tests(; core = ...), running the umbrella-load testset. Move test/Core/umbrella_load.jl to test/umbrella_load.jl (the core body reads the top-level test file). Add SciMLTesting to the root test deps; keep Pkg (the sublibrary pre-step still uses it). test/test_groups.toml is unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the root test suite to use SciMLTesting v1.2.
This is a monorepo: the sublibraries under
lib/are tested by the separateSublibraryCI.yml(sublibrary-project-tests.yml, project model —tests.ymlgit-develops each sublibrary's in-repo[sources], no root dispatcher needed). The rootCI.ymlrunsgrouped-tests.yml, whose root matrix is computed fromtest/test_groups.toml(which declares only[Core]), so the rootruntests.jlis only ever invoked withGROUP=Core(or theAlldefault).Changes:
test/runtests.jlnow doesusing SciMLTestingand:<1.11transitive[sources]develop walk and the exactwithenv(OPTIMALUNCERTAINTYQUANTIFICATION_TEST_GROUP => ...) Pkg.test(sublib; julia_args=..., force_latest_compatible_version=false, allow_reresolve=true)invocation) so the sublibPkg.teststays byte-for-byte;_detect_sublibrary_groupclosure with the exportedSciMLTesting.detect_sublibrary_group(verified to return identical(sublibrary, test_group)pairs for every relevantGROUPvalue, including the no-match fall-through);Core/Allgroup throughrun_tests(; core = ...), running the umbrella-load testset.test/Core/umbrella_load.jlis moved totest/umbrella_load.jl(thecorebody reads the top-level test file; the emptytest/Core/directory is removed).SciMLTestingto the root test deps ([extras]/[targets].test/[compat]).Pkgis retained — it is still used by the sublibrary pre-step.test/test_groups.tomlis unchanged.Behavior-preserving: the set of tests run under each
GROUPvalue is unchanged (Core/All-> umbrella load;<sublib>/<sublib>_<grp>-> the same sublibraryPkg.test).Ignore until reviewed by @ChrisRackauckas.