QA: normalize versions to [lts,1] (drop pre)#69
Merged
Conversation
The root test/test_groups.toml [QA] group ran Aqua/JET on the latest stable channel only (["1"]). Normalize to the canonical set ["lts", "1"] so QA also runs on the LTS (1.10) channel, matching the rest of the SciML fleet. The repo's [compat] julia floor is 1.10 (== LTS), so the lts slot is used directly (no floor exception). Only [QA].versions is changed; other groups are untouched. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # test/test_groups.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalizes the root
test/test_groups.toml[QA]group'sversionsto the canonical SciML set.Change:
[QA].versions["1"]->["lts", "1"]The
[QA]group (Aqua / ExplicitImports / JET) previously ran on the latest stable channel only. The canonical fleet convention runs QA on both the LTS channel and the latest stable. This repo's[compat] juliafloor is1.10(equal to current LTS), so theltsslot is used directly with no floor exception.preis intentionally not included for QA.Only
[QA].versionsis touched;[Core]and[LineSearchesJL]are unchanged. Verified the file still parses as valid TOML.Ignore until reviewed by @ChrisRackauckas.