Skip to content

Fix Format Check: format FastPowerEnzymeExt.jl (SciMLStyle)#56

Draft
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:fix/format-enzyme-ext
Draft

Fix Format Check: format FastPowerEnzymeExt.jl (SciMLStyle)#56
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:fix/format-enzyme-ext

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

What

The Format Check / Check Formatting job on main was failing. That job runs the SciML shared workflow SciML/.github/.github/workflows/format-check.yml@v1, which applies JuliaFormatter v2 with SciMLStyle() and fails if any file changes.

Locally reproduced on Julia 1.12 (the "1" channel) with JuliaFormatter v2.8.0:

format(".", SciMLStyle(), verbose=true)  # => false (changes needed)
git diff --name-only                     # => ext/FastPowerEnzymeExt.jl

The only unformatted file was ext/FastPowerEnzymeExt.jl (the @easy_rule macro call argument layout). This PR applies the canonical formatting. Re-running the formatter afterward reports the tree as already formatted (true), so the Format Check will pass. The change is purely cosmetic with no semantic effect.

Note: the other red checks on main are downstream tests (OrdinaryDiffEq.jl, SimpleDiffEq.jl) which are out of scope for this repo's own CI.

Local verification

  • julia +1.12 with JuliaFormatter v2.8.0 + SciMLStyle: before = needs change (only this file), after = already formatted.

Please ignore until reviewed by @ChrisRackauckas

The Format Check CI (SciML/.github format-check.yml@v1, JuliaFormatter v2
SciMLStyle) was red on main because ext/FastPowerEnzymeExt.jl was not
formatted. Applying `format(".", SciMLStyle())` only touches this one file;
re-running afterward reports the tree as already formatted. Purely cosmetic;
no semantic change.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor Author

Status update: this PR is now obsolete and should not be merged.

It reformats ext/FastPowerEnzymeExt.jl with JuliaFormatter v2 SciMLStyle() to satisfy a Format Check / Check Formatting job that ran SciML/.github/.github/workflows/format-check.yml@v1. That workflow has since been replaced on main by SciML/.github/.github/workflows/runic.yml@v1 (the runic / Runic Format Check check), which is green on the current main HEAD.

Verified locally with Runic v1.7.0: Runic.format_string reports every .jl file in the repo — including ext/FastPowerEnzymeExt.jl — as already formatted (no diff). The PR is also CONFLICTING against the current main.

Recommend closing without merge; the format check it targeted no longer exists and the tree is already Runic-clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants