Skip to content

Canonicalize tests to @safetestset for module isolation #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisRackauckas-Claude wants to merge 1 commit into from
Closed

Canonicalize tests to @safetestset for module isolation #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Measurements = "2"
MonteCarloMeasurements = "1"
Mooncake = "0.4"
ReverseDiff = "1"
SafeTestsets = "0.1, 1"
Tracker = "0.2"
julia = "1.10"

Expand All @@ -39,8 +40,9 @@ EnzymeTestUtils = "12d8515a-0907-448a-8884-5fe00fdf1c5a"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
Mooncake = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6"
ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test", "Enzyme", "EnzymeTestUtils", "ForwardDiff", "Mooncake", "ReverseDiff", "Tracker"]
test = ["Test", "Enzyme", "EnzymeTestUtils", "ForwardDiff", "Mooncake", "ReverseDiff", "Tracker", "SafeTestsets"]
41 changes: 28 additions & 13 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
using FastPower
using FastPower: fastlog2, fastpower
using Enzyme, EnzymeTestUtils
using ForwardDiff, ReverseDiff, Tracker, Mooncake
using Test
using SafeTestsets, Test

@safetestset "Fast log2" begin
using FastPower: fastlog2
using Test

@testset "Fast log2" begin
for x in 0.001:0.001:1.2 # (0, 1+something] is the domain which a controller uses
@test log2(x)≈fastlog2(Float32(x)) atol=1e-3
end
end

@testset "Fast pow" begin
@safetestset "Fast pow" begin
using FastPower: fastpower
using Test

@test fastpower(1, 1) isa Float64
@test fastpower(1.0, 1.0) isa Float64
errors = [abs(^(x, y) - fastpower(x, y)) for x in 0.001:0.001:1, y in 0.08:0.001:0.5]
Expand All @@ -23,7 +25,11 @@ end
@test maximum(errors) < 1e-2
end

@testset "Fast pow - Enzyme forward rule" begin
@safetestset "Fast pow - Enzyme forward rule" begin
using FastPower: fastpower
using Enzyme, EnzymeTestUtils
using Test

@testset for RT in (Duplicated, DuplicatedNoNeed),
Tx in (Const, Duplicated),
Ty in (Const, Duplicated)
Expand All @@ -33,18 +39,27 @@ end
end
end

@testset "Fast pow - Enzyme reverse rule" begin
@safetestset "Fast pow - Enzyme reverse rule" begin
using FastPower: fastpower
using Enzyme, EnzymeTestUtils
using Test

@testset for RT in (Active,), Tx in (Active, Const), Ty in (Active, Const)
x = 1.0
y = 0.5
test_reverse(fastpower, RT, (x, Tx), (y, Ty), atol = 1e-4, rtol = 1e-3)
end
end

function mooncake_derivative(f, x)
Mooncake.value_and_gradient!!(Mooncake.build_rrule(f, x), f, x)[2][2]
end
@testset "Fast pow - Other AD Engines" begin
@safetestset "Fast pow - Other AD Engines" begin
using FastPower: fastpower
using ForwardDiff, ReverseDiff, Tracker, Mooncake
using Test

function mooncake_derivative(f, x)
Mooncake.value_and_gradient!!(Mooncake.build_rrule(f, x), f, x)[2][2]
end

x = 1.5123233245141
y = 0.22352354326
@test ForwardDiff.derivative(x -> fastpower(x, x + y), x) ≈
Expand Down