ci: drop removed allow-reresolve input from Downgrade caller#309
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
ci: drop removed allow-reresolve input from Downgrade caller#309ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
The central reusable workflow SciML/.github/.github/workflows/downgrade.yml@v1 was retagged and no longer declares an `allow-reresolve` input. Passing it from this caller's `with:` block causes the Downgrade job to error with an invalid-input failure. Remove the stale line so the caller matches the current v1 interface. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by #307 (same allow-reresolve removal + the downgrade enable/disable decision). Closing this duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the now-invalid
allow-reresolve: falseline from thewith:block of the centralized Downgrade caller in.github/workflows/Downgrade.yml.Why
The central reusable workflow
SciML/.github/.github/workflows/downgrade.yml@v1was retagged and no longer declares anallow-reresolveinput. GitHub Actions errors when a caller passes awith:key that the called reusable workflow does not declare, so on the default branch the Downgrade job now fails with an invalid-input error.This caller is the last remaining one in the repo still passing the removed input. Dropping the single line realigns it with the current v1 interface.
Verified against the live central workflow:
gh api repos/SciML/.github/contents/.github/workflows/downgrade.yml?ref=v1-> noallow-reresolveinput declared.Scope
git show --stat:Only the single
allow-reresolve: falseline is removed; no other behavior changes. (Note: thetestjob remainsif: false/disabled per issue #292 — that is unchanged here.)Please ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code