feat(claude-code-settings): improve test coverage#5385
Open
miteshashar wants to merge 1 commit intoSchemaStore:masterfrom
Open
feat(claude-code-settings): improve test coverage#5385miteshashar wants to merge 1 commit intoSchemaStore:masterfrom
miteshashar wants to merge 1 commit intoSchemaStore:masterfrom
Conversation
Schema: - Add fastMode boolean property (default: false) - Add default: true to sandbox.autoAllowBashIfSandboxed - Enhance spinnerVerbs.mode description with enum explanations - Add 19 missing property descriptions (statusLine, fileSuggestion, sandbox.network, 14 marketplace source type discriminators) Tests: - Add 13 uncovered top-level properties to modern-complete-config.json - Add untested enum values across 6 test files (all 7 enums fully covered) - Add non-default value tests for 9 properties (edge-cases, basic-config) - Add git URL pattern test to marketplace-host-pattern.json - Add defaultMode coverage across permissions test files Negative tests: - Add 4 invalid enum values to invalid-enum-values.json - Add git URL pattern violation to invalid-marketplace-host-pattern.json - Create invalid-mcp-server-name.json for serverName pattern violations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thanks for the PR! This section of the codebase is owned by @domdomegg and @bogini - if they write a comment saying "LGTM" then it will be merged. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema
fastModeboolean property (default: false) per fast-mode documentation (v2.1.47)default: truetosandbox.autoAllowBashIfSandboxedper sandboxing documentationspinnerVerbs.modedescription with explicit enum value explanationsstatusLine.type/command/padding,fileSuggestion.type,sandbox.network, 14 marketplace source type discriminators acrossextraKnownMarketplacesandstrictKnownMarketplacesTests
modern-complete-config.json(allowManagedPermissionRulesOnly, awsAuthRefresh, awsCredentialExport, companyAnnouncements, disableAllHooks, enabledPlugins, forceLoginOrgUUID, otelHeadersHelper, pluginConfigs, skipWebFetchPreflight, skippedMarketplaces, skippedPlugins, statusLine)edge-cases.jsonandbasic-config.jsondefaultModeenum coverage acrosspermissions-basic.json,permissions-mcp.json,complete-config.json,edge-cases.json(all 6 values now tested)marketplace-host-pattern.jsonNegative tests
invalid-enum-values.json(autoUpdatesChannel, effortLevel, disableBypassPermissionsMode, teammateMode)invalid-marketplace-host-pattern.jsoninvalid-mcp-server-name.jsonfor serverName pattern violationsCoverage analysis
Identified using the coverage analysis tool from #5383.
Before (3 passed, 5 failed)
After (7 passed, 0 failed, 1 warned)
Supersedes #5384 (closed due to accidentally including coverage tool changes from #5383).
🤖 Generated with Claude Code